Don't fetch segments when videoID is null

Also log an error to the console if we ever try to do this in the future
This commit is contained in:
mini-bomba 2024-06-13 01:18:02 +02:00
parent f48c57b1c5
commit 0b946d5ef7
No known key found for this signature in database
GPG key ID: 30F8B138B4794886

View file

@ -264,7 +264,9 @@ function messageListener(request: Message, sender: unknown, sendResponse: (respo
// it will assume the page is not a video page and stop the refresh animation
sendResponse({ hasVideo: getVideoID() != null });
// fetch segments
sponsorsLookup(false);
if (getVideoID()) {
sponsorsLookup(false);
}
break;
case "unskip":
@ -1115,7 +1117,12 @@ async function sponsorsLookup(keepOldSubmissions = true) {
const hashParams = getHashParams();
if (hashParams.requiredSegment) extraRequestData.requiredSegment = hashParams.requiredSegment;
const hashPrefix = (await getHash(getVideoID(), 1)).slice(0, 4) as VideoID & HashedValue;
const videoID = getVideoID()
if (!videoID) {
console.error("[SponsorBlock] Attempted to fetch segments with a null/undefined videoID.");
return;
}
const hashPrefix = (await getHash(videoID, 1)).slice(0, 4) as VideoID & HashedValue;
const response = await asyncRequestToServer('GET', "/api/skipSegments/" + hashPrefix, {
categories,
actionTypes: getEnabledActionTypes(),
@ -2733,4 +2740,4 @@ function checkForMiniplayerPlaying() {
}
}
}
}
}