Fixed buttons appearing on invidious.

This commit is contained in:
Ajay Ramachandran 2020-01-09 21:32:56 -05:00
parent a20fa9871e
commit 338fbcea9c
2 changed files with 8 additions and 15 deletions

View file

@ -58,12 +58,6 @@ var lastSponsorTimeSkippedUUID = null;
//if showing the start sponsor button or the end sponsor button on the player //if showing the start sponsor button or the end sponsor button on the player
var showingStartSponsor = true; var showingStartSponsor = true;
//should the video controls buttons be added
//TODO: If invidious gets video controls, change the code where this is set from chrome.sync as well.
var hideVideoPlayerControls = onInvidious;
var hideInfoButtonPlayerControls = onInvidious;
var hideDeleteButtonPlayerControls = onInvidious;
//the sponsor times being prepared to be submitted //the sponsor times being prepared to be submitted
var sponsorTimesSubmitting = []; var sponsorTimesSubmitting = [];
@ -653,7 +647,7 @@ async function updateVisibilityOfPlayerControlsButton() {
await createButtons(); await createButtons();
if (SB.config.hideVideoPlayerControls) { if (SB.config.hideVideoPlayerControls || onInvidious) {
document.getElementById("startSponsorButton").style.display = "none"; document.getElementById("startSponsorButton").style.display = "none";
document.getElementById("submitButton").style.display = "none"; document.getElementById("submitButton").style.display = "none";
} else { } else {
@ -661,13 +655,13 @@ async function updateVisibilityOfPlayerControlsButton() {
} }
//don't show the info button on embeds //don't show the info button on embeds
if (SB.config.hideInfoButtonPlayerControls || document.URL.includes("/embed/")) { if (SB.config.hideInfoButtonPlayerControls || document.URL.includes("/embed/") || onInvidious) {
document.getElementById("infoButton").style.display = "none"; document.getElementById("infoButton").style.display = "none";
} else { } else {
document.getElementById("infoButton").style.removeProperty("display"); document.getElementById("infoButton").style.removeProperty("display");
} }
if (SB.config.hideDeleteButtonPlayerControls) { if (SB.config.hideDeleteButtonPlayerControls || onInvidious) {
document.getElementById("deleteButton").style.display = "none"; document.getElementById("deleteButton").style.display = "none";
} }
} }

View file

@ -126,8 +126,6 @@ function invidiousInstanceAddInit(element, option) {
alert(chrome.i18n.getMessage("addInvidiousInstanceError")); alert(chrome.i18n.getMessage("addInvidiousInstanceError"));
} else { } else {
// Add this // Add this
//TODO Make the call to invidiousOnClick support passing the straight extra values, plus make the get not needed
//OR merge the config PR and use that
let instanceList = SB.config[option]; let instanceList = SB.config[option];
if (!instanceList) instanceList = []; if (!instanceList) instanceList = [];
@ -151,7 +149,8 @@ function invidiousInstanceAddInit(element, option) {
let resetButton = element.querySelector(".invidious-instance-reset"); let resetButton = element.querySelector(".invidious-instance-reset");
resetButton.addEventListener("click", function(e) { resetButton.addEventListener("click", function(e) {
if (confirm(chrome.i18n.getMessage("resetInvidiousInstanceAlert"))) { if (confirm(chrome.i18n.getMessage("resetInvidiousInstanceAlert"))) {
SB.config[option] = SB.defaults[option]; // Set to a clone of the default
SB.config[option] = SB.defaults[option].slice(0);
} }
}); });
} }