From 9b572609f87662e01f23b0ce77813b7c50bf5fd5 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Mon, 14 Dec 2020 23:51:23 -0500 Subject: [PATCH 1/5] Fix popup padding on YouTube page --- public/popup.css | 2 +- public/popup.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/popup.css b/public/popup.css index 70e3c481..dcad93b0 100644 --- a/public/popup.css +++ b/public/popup.css @@ -18,7 +18,7 @@ flex-flow: column nowrap; align-items: center; width: 330px; - margin: 22px; + padding: 22px; text-align: center; } diff --git a/public/popup.html b/public/popup.html index 80755e8b..13940a6f 100644 --- a/public/popup.html +++ b/public/popup.html @@ -4,7 +4,7 @@ - +
From 865422eaaa58e6c57247fb96b2a123f45601b775 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Mon, 14 Dec 2020 23:56:56 -0500 Subject: [PATCH 2/5] Fix help link on popup --- public/popup.html | 2 +- src/background.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/popup.html b/public/popup.html index 13940a6f..84528ef5 100644 --- a/public/popup.html +++ b/public/popup.html @@ -135,7 +135,7 @@
Discord | Matrix | - __MSG_help__ + __MSG_help__ diff --git a/src/background.ts b/src/background.ts index 2bab479f..71ce4e09 100644 --- a/src/background.ts +++ b/src/background.ts @@ -33,7 +33,7 @@ chrome.runtime.onMessage.addListener(function (request, sender, callback) { chrome.runtime.openOptionsPage(); return; case "openHelp": - window.open(chrome.runtime.getURL('help/index_en.html')); + chrome.tabs.create({url: chrome.runtime.getURL('help/index_en.html')}); return; case "sendRequest": sendRequestToCustomServer(request.type, request.url, request.data).then(async (response) => { From 17eead2bb694e589689c95ca085de1b109d55d4b Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Tue, 15 Dec 2020 13:50:06 -0500 Subject: [PATCH 3/5] Use short category name in popup --- src/popup.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/popup.ts b/src/popup.ts index 1ccc7cae..aba3d8c0 100644 --- a/src/popup.ts +++ b/src/popup.ts @@ -375,7 +375,7 @@ async function runThePopup(messageListener?: MessageListener): Promise { const sponsorTimeButton = document.createElement("button"); sponsorTimeButton.className = "segmentTimeButton popupElement"; - const prefix = chrome.i18n.getMessage("category_" + segmentTimes[i].category) + ": "; + const prefix = utils.shortCategoryName(segmentTimes[i].category) + ": "; let extraInfo = ""; if (segmentTimes[i].hidden === SponsorHideType.Downvoted) { From e31aaba24cac3484acc75d70eb32cab0c8065772 Mon Sep 17 00:00:00 2001 From: Ajay Ramachandran Date: Tue, 15 Dec 2020 14:02:08 -0500 Subject: [PATCH 4/5] Fix website text not using strings in popup --- public/popup.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/popup.html b/public/popup.html index 84528ef5..33119900 100644 --- a/public/popup.html +++ b/public/popup.html @@ -129,7 +129,7 @@ __MSG_minsLower__).