Merge pull request #225 from ajayyy/experimental-ajay

Option page fixes
This commit is contained in:
Ajay Ramachandran 2020-01-09 19:53:40 -05:00 committed by GitHub
commit 4301a6bfe3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 14 deletions

1
.gitignore vendored
View file

@ -3,3 +3,4 @@ ignored
.idea/
node_modules
web-ext-artifacts
.vscode/

View file

@ -83,6 +83,12 @@
vertical-align: middle;
}
.profilepiccircle {
vertical-align: middle;
overflow: hidden;
border-radius: 50%;
}
a {
text-decoration: underline;
color: inherit;

View file

@ -26,7 +26,7 @@
<div option-type="toggle" toggle-type="reverse" sync-option="disableAutoSkip">
<label class="switch-container" label-name="__MSG_autoSkip__">
<label class="switch">
<input type="checkbox">
<input type="checkbox" checked>
<span class="slider round"></span>
</label>
</label>
@ -85,7 +85,7 @@
<div option-type="toggle" toggle-type="reverse" sync-option="hideVideoPlayerControls">
<label class="switch-container" label-name="__MSG_showButtons__">
<label class="switch">
<input type="checkbox">
<input type="checkbox" checked>
<span class="slider round"></span>
</label>
</label>
@ -102,7 +102,7 @@
<div option-type="toggle" toggle-type="reverse" sync-option="hideInfoButtonPlayerControls">
<label class="switch-container" label-name="__MSG_showInfoButton__">
<label class="switch">
<input type="checkbox">
<input type="checkbox" checked>
<span class="slider round"></span>
</label>
</label>
@ -119,7 +119,7 @@
<div option-type="toggle" toggle-type="reverse" sync-option="hideDeleteButtonPlayerControls">
<label class="switch-container" label-name="__MSG_showDeleteButton__">
<label class="switch">
<input type="checkbox">
<input type="checkbox" checked>
<span class="slider round"></span>
</label>
</label>
@ -150,7 +150,7 @@
<br/>
<br/>
<div option-type="text-change" sync-option="userID">
<div option-type="text-change" sync-option="userID" confirm-message="userIDChangeWarning">
<div class="option-button trigger-button">
__MSG_changeUserID__
</div>
@ -179,7 +179,7 @@
<div option-type="toggle" toggle-type="reverse" sync-option="dontShowNotice">
<label class="switch-container" label-name="__MSG_showSkipNotice__">
<label class="switch">
<input type="checkbox">
<input type="checkbox" checked>
<span class="slider round"></span>
</label>
</label>

View file

@ -118,7 +118,13 @@ function activateTextChange(element) {
textBox.value = SB.config[option];
let setButton = element.querySelector(".text-change-set");
setButton.addEventListener("click", () => {SB.config[option] = textBox.value});
setButton.addEventListener("click", () => {
let confirmMessage = element.getAttribute("confirm-message");
if (confirmMessage === null || confirm(chrome.i18n.getMessage(confirmMessage))) {
SB.config[option] = textBox.value;
}
});
element.querySelector(".option-hidden-section").classList.remove("hidden");
}

View file

@ -57,13 +57,6 @@ function localizeHtmlPage() {
let localizedMessage = getLocalizedMessage(obj.innerHTML.toString());
if (localizedMessage) obj.innerHTML = localizedMessage;
// Try on each attribute
let attributes = obj.getAttributeNames();
for (const attribute of attributes) {
localizedMessage = getLocalizedMessage(obj.getAttribute(attribute).toString());
if (localizedMessage) obj.setAttribute(attribute) = localizedMessage;
}
}
}