external/SponsorBlockServer
1
0
Fork 0
mirror of https://github.com/ajayyy/SponsorBlockServer.git synced 2024-11-10 09:07:47 +01:00
Code Issues Projects Releases Packages Wiki Activity

Added [] return rather than 404 for no segments with matching hash

Browse source
This commit is contained in:
Joe Dowd 2020-10-01 00:51:58 +01:00
parent 211562a0d6
commit 4cea3c2a3b
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/routes/getSkipSegmentsByHash.js
View file

@ -20,10 +20,10 @@ module.exports = async function (req, res) {
// Get all video id's that match hash prefix
const videoIds = db.prepare('all', 'SELECT DISTINCT videoId, hashedVideoID from sponsorTimes WHERE hashedVideoID LIKE ?', [hashPrefix+'%']);
if (videoIds.length === 0) {
/*if (videoIds.length === 0) {
res.sendStatus(404);
return;
}
}*/
let segments = videoIds.map((video) => {
return {

17
test/cases/getSegmentsByHash.js
View file

@ -40,7 +40,7 @@ describe('getSegmentsByHash', () => {
});
});
it('Should be able to get a 404 if no videos', (done) => {
/*it('Should be able to get a 404 if no videos', (done) => {
request.get(utils.getbaseURL()
+ '/api/skipSegments/11111?categories=["shilling"]', null,
(err, res, body) => {
@ -50,8 +50,23 @@ describe('getSegmentsByHash', () => {
done(); // pass
}
});
});*/
it('Should be able to get an emptry array if no videos', (done) => {
request.get(utils.getbaseURL()
+ '/api/skipSegments/11111?categories=["shilling"]', null,
(err, res, body) => {
if (err) done("Couldn't call endpoint");
else if (res.statusCode !== 200) done("non 200 status code, was " + res.statusCode);
else {
if (JSON.parse(body).length === 0) done(); // pass
else done("non empty array returned");
}
});
});
it('Should return 400 prefix too short', (done) => {
request.get(utils.getbaseURL()
+ '/api/skipSegments/11?categories=["shilling"]', null,