external/invidious
1
0
Fork 0
mirror of https://github.com/iv-org/invidious.git synced 2024-11-10 01:01:57 +01:00
Code Issues Projects Releases Packages Wiki Activity

videos: Fix XSS vulnerability in description/comments

Browse source 
Patch provided by e-mail, thanks to an anonymous user whose cats are named
Yoshi and Yasuo.

Comment is mine
This commit is contained in:
Samantaz Fox 2024-08-15 18:26:17 +02:00
parent e319c35f09
commit 0b28054f8a
No known key found for this signature in database
GPG key ID: F42821059186176E
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/invidious/videos/description.cr
View file

@ -36,7 +36,13 @@ def parse_description(desc, video_id : String) : String?
return "" if content.empty? return "" if content.empty?
commands = desc["commandRuns"]?.try &.as_a commands = desc["commandRuns"]?.try &.as_a
return content if commands.nil? if commands.nil?
# Slightly faster than HTML.escape, as we're only doing one pass on
# the string instead of five for the standard library
return String.build do |str|
copy_string(str, content.each_codepoint, content.size)
end
end
# Not everything is stored in UTF-8 on youtube's side. The SMP codepoints # Not everything is stored in UTF-8 on youtube's side. The SMP codepoints
# (0x10000 and above) are encoded as UTF-16 surrogate pairs, which are # (0x10000 and above) are encoded as UTF-16 surrogate pairs, which are