Add missing DELETE endpoint for Budgets

src/repository/budget/budgetRepository.ts

@@ -1,7 +1,8 @@
-import { type Budget } from "../../domain/budget";
+import { type Budget, type BudgetId } from "../../domain/budget";
 
 interface BudgetRepository {
   findAll: () => Promise<Budget[]>;
+  delete: (id: BudgetId) => Promise<{ deleted: boolean }>;
 }
 
 export default BudgetRepository;

src/repository/budget/mongo/budgetMongoRepository.ts

@@ -7,8 +7,14 @@ export const findBudgets: BudgetRepository["findAll"] = async () => {
   return found.map(BudgetEntityConverter.toDomain);
 };
 
+export const deleteBudget: BudgetRepository["delete"] = async (budgetId) => {
+  const deleted = await BudgetSummaryModel.deleteOne({ id: budgetId.value });
+  return { deleted: deleted.deletedCount > 0 };
+};
+
 const BudgetMongoRepository = (): BudgetRepository => ({
   findAll: findBudgets,
+  delete: deleteBudget,
 });
 
 export default BudgetMongoRepository;

src/routes/budget/budgetRouter.ts

@@ -45,6 +45,16 @@ export const getBudgetSummary =
     }
   };
 
+export const deleteBudget =
+  (deleteBudget: BudgetUseCases["deleteBudget"]) =>
+  async (req: Request, res: Response): Promise<void> => {
+    const budgetId = new UUID(req.params.budgetId);
+    const deleteResult = await deleteBudget(budgetId);
+    res.status(
+      deleteResult.deleted ? StatusCodes.NO_CONTENT : StatusCodes.NOT_FOUND
+    );
+  };
+
 const BudgetRouter = (budgetUseCases: BudgetUseCases): Router => {
   const router = Router();
   router.post(
@@ -59,6 +69,10 @@ const BudgetRouter = (budgetUseCases: BudgetUseCases): Router => {
     toExpressPath(apiPaths.getBudgetSummary),
     asyncHandler(getBudgetSummary(budgetUseCases.getBudgetSummary))
   );
+  router.delete(
+    toExpressPath(apiPaths.deleteBudget),
+    asyncHandler(deleteBudget(budgetUseCases.deleteBudget))
+  );
 
   return router;
 };

src/routes/toExpressPath.ts

@@ -1,3 +1,8 @@
+/**
+ * Reformats an OpenAPI defined path to a by Express readable path
+ * I.e. rewrites path param notation from OpenAPI format to Express format
+ * @param openApiPath The in the OpenAPI spec defined path
+ */
 const toExpressPath = (openApiPath: string): string =>
   openApiPath.replaceAll(/({)(.*)(})/g, ":$2");
 

src/usecase/budget/budgetService.ts

@@ -3,6 +3,7 @@ import type BudgetSummaryRepository from "../../repository/budget/budgetSummaryR
 import type BudgetUseCases from "./budgetUseCases";
 import UUID from "../../domain/uuid";
 import type BudgetRepository from "../../repository/budget/budgetRepository";
+import budgetRepository from "../../repository/budget/budgetRepository";
 
 export const createBudget: (
   insertBudget: BudgetSummaryRepository["insert"]
@@ -28,6 +29,13 @@ export const getBudgets: (
   return await findAll();
 };
 
+export const deleteBudget: (
+  deleteFromPersistence: BudgetRepository["delete"]
+) => BudgetUseCases["deleteBudget"] =
+  (deleteFromPersistence) => async (budgetId) => {
+    return await deleteFromPersistence(budgetId);
+  };
+
 const BudgetService: (
   budgetSummaryRepo: BudgetSummaryRepository,
   budgetRepo: BudgetRepository
@@ -35,6 +43,7 @@ const BudgetService: (
   createBudget: createBudget(budgetSummaryRepo.insert),
   getBudgetSummary: getBudgetSummary(budgetSummaryRepo.find),
   getBudgets: getBudgets(budgetRepo.findAll),
+  deleteBudget: deleteBudget(budgetRepo.delete),
 });
 
 export default BudgetService;

src/usecase/budget/budgetUseCases.ts

@@ -9,6 +9,7 @@ interface BudgetUseCases {
   createBudget: (newBudget: NewBudget) => Promise<Budget>;
   getBudgetSummary: (budgetId: BudgetId) => Promise<BudgetSummary | undefined>;
   getBudgets: () => Promise<Budget[]>;
+  deleteBudget: (budgetId: BudgetId) => Promise<{ deleted: boolean }>;
 }
 
 export default BudgetUseCases;