From 196d9fe4d2a4b74198000cebd11e8c2917d6c33e Mon Sep 17 00:00:00 2001 From: KobeW50 <84587632+KobeW50@users.noreply.github.com> Date: Sun, 15 Oct 2023 05:56:02 -0400 Subject: [PATCH] refactor: reorganize and rename settings (#1307) Co-authored-by: Pun Butrach Co-authored-by: Ushie --- assets/i18n/en_US.json | 96 +++++++-------- docs/2_4_settings.md | 42 ++++--- fonts/custom-icons.ttf | Bin 0 -> 1892 bytes lib/services/manager_api.dart | 10 +- .../views/installer/installer_viewmodel.dart | 6 +- lib/ui/views/patcher/patcher_viewmodel.dart | 2 +- .../patches_selector_viewmodel.dart | 4 +- lib/ui/views/settings/settings_view.dart | 9 +- lib/ui/views/settings/settings_viewmodel.dart | 8 +- .../widgets/homeView/latest_commit_card.dart | 4 +- .../patchesSelectorView/patch_item.dart | 15 ++- .../settings_advanced_section.dart | 89 ++------------ .../settingsView/settings_debug_section.dart | 68 +++++++++++ .../settingsView/settings_export_section.dart | 113 ++++++++++++------ .../settingsView/settings_info_section.dart | 38 ------ ...s.dart => settings_universal_patches.dart} | 16 +-- ...settings_version_compatibility_check.dart} | 16 +-- .../settingsView/social_media_widget.dart | 7 ++ lib/ui/widgets/shared/custom_icon.dart | 9 ++ pubspec.yaml | 4 + 20 files changed, 285 insertions(+), 271 deletions(-) create mode 100644 fonts/custom-icons.ttf create mode 100644 lib/ui/widgets/settingsView/settings_debug_section.dart delete mode 100644 lib/ui/widgets/settingsView/settings_info_section.dart rename lib/ui/widgets/settingsView/{settings_experimental_universal_patches.dart => settings_universal_patches.dart} (75%) rename lib/ui/widgets/settingsView/{settings_experimental_patches.dart => settings_version_compatibility_check.dart} (69%) create mode 100644 lib/ui/widgets/shared/custom_icon.dart diff --git a/assets/i18n/en_US.json b/assets/i18n/en_US.json index f61c6192..9185c6d0 100644 --- a/assets/i18n/en_US.json +++ b/assets/i18n/en_US.json @@ -128,12 +128,10 @@ "none": "None", "noneTooltip": "Deselect all patches", - "loadPatchesSelection": "Load patches selection", - "noSavedPatches": "No saved patches for the selected app.\nPress Done to save current selection.", + "loadPatchesSelection": "Load patch selection", + "noSavedPatches": "No saved patch selection for the selected app.\nPress Done to save the current selection.", "noPatchesFound": "No patches found for the selected app", - "setRequiredOption": "Some patches require options to be set:\n\n{patches}\n\nPlease set them before continuing.", - - "selectAllPatchesWarningContent": "You are about to select all patches, that includes non-suggested patches and can cause unwanted behavior." + "setRequiredOption": "Some patches require options to be set:\n\n{patches}\n\nPlease set them before continuing." }, "patchOptionsView": { "viewTitle": "Patch options", @@ -152,10 +150,10 @@ }, "patchItem": { "unsupportedDialogText": "Selecting this patch may result in patching errors.\n\nApp version: {packageVersion}\nSupported versions:\n{supportedVersions}", - "unsupportedPatchVersion": "Patch is not supported for this app version. Enable the experimental toggle in settings to proceed.", + "unsupportedPatchVersion": "Patch is not supported for this app version.", "unsupportedRequiredOption": "This patch contains a required option that is not supported by this app", - "patchesChangeWarningDialogText": "It is recommended to use the default selection of patches because changing it may cause unexpected issues.\n\nIf you know what you are doing, you can enable \"Enable changing selection\" in the settings.", + "patchesChangeWarningDialogText": "It is recommended to use the default patch selection and options. Changing them may result in unexpected issues.\n\nYou'll need to turn on \"Allow changing patch selection\" in settings before changing any patch selection.", "patchesChangeWarningDialogButton": "Use default selection" }, "installerView": { @@ -187,10 +185,9 @@ "appearanceSectionTitle": "Appearance", "teamSectionTitle": "Team", - "infoSectionTitle": "Info", + "debugSectionTitle": "Debugging", "advancedSectionTitle": "Advanced", "exportSectionTitle": "Import & export", - "logsSectionTitle": "Logs", "themeModeLabel": "App theme", "systemThemeLabel": "System", @@ -204,15 +201,15 @@ "englishOption": "English", "sourcesLabel": "Sources", - "sourcesLabelHint": "Configure your custom sources", + "sourcesLabelHint": "Configure your sources", "sourcesIntegrationsLabel": "Integrations source", "sourcesResetDialogTitle": "Reset", - "sourcesResetDialogText": "Are you sure you want to reset custom sources to their default values?", - "apiURLResetDialogText": "Are you sure you want to reset API URL to its default value?", - "sourcesUpdateNote": "Note: ReVanced Patches will be updated to the latest version automatically.\n\nThis will reveal your IP address to the server.", + "sourcesResetDialogText": "Are you sure you want to reset your sources to their default values?", + "apiURLResetDialogText": "Are you sure you want to reset your API URL to its default value?", + "sourcesUpdateNote": "Note: Patches will be updated to the latest version automatically.\n\nThis will reveal your IP address to the server.", "apiURLLabel": "API URL", - "apiURLHint": "Configure your custom API URL", + "apiURLHint": "Configure your API URL", "selectApiURL": "API URL", "hostRepositoryLabel": "Repository API", "orgPatchesLabel": "Patches organization", @@ -222,21 +219,20 @@ "contributorsLabel": "Contributors", "contributorsHint": "A list of contributors of ReVanced", - "logsLabel": "Logs", - "logsHint": "Share Manager's logs", + "logsLabel": "Share logs", + "logsHint": "Share ReVanced Manager logs", - "enablePatchesSelectionLabel": "Enable changing selection", - "enablePatchesSelectionHint": "Enable changing the selection of patches.", - "enablePatchesSelectionWarningText": "Changing the default selection of patches may cause unexpected issues.\n\nEnable anyways?", + "enablePatchesSelectionLabel": "Allow changing patch selection", + "enablePatchesSelectionHint": "Allow changing the selection of patches", + "enablePatchesSelectionWarningText": "Changing the selection of patches may cause unexpected issues.\n\nEnable anyways?", "disablePatchesSelectionWarningText": "You are about to disable changing the selection of patches.\nThe default selection of patches will be restored.\n\nDisable anyways?", "autoUpdatePatchesLabel": "Auto update patches", - "autoUpdatePatchesHint": "Automatically update ReVanced Patches to the latest version", - "experimentalUniversalPatchesLabel": "Experimental universal patches support", - "experimentalUniversalPatchesHint": "Display all applications to use with universal patches, loading list of apps may be slower", - "experimentalPatchesLabel": "Experimental patches support", - "experimentalPatchesHint": "Enable usage of unsupported patches in any app version", - "enabledExperimentalPatches": "Experimental patches support enabled", + "autoUpdatePatchesHint": "Automatically update patches to the latest version", + "universalPatchesLabel": "Show universal patches", + "universalPatchesHint": "Display all apps and universal patches (may slow down the app list)", + "versionCompatibilityCheckLabel": "Version compatibility check", + "versionCompatibilityCheckHint": "Restricts patches to supported versions", "aboutLabel": "About", "snackbarMessage": "Copied to clipboard", @@ -246,54 +242,52 @@ "deleteTempDirHint": "Delete unused temporary files", "deletedTempDir": "Temporary files deleted", - "exportPatchesLabel": "Export patches selection", - "exportPatchesHint": "Export patches selection to a JSON file", - "exportedPatches": "Patches selection exported", - "noExportFileFound": "No patches selection to export", + "exportPatchesLabel": "Export patch selection", + "exportPatchesHint": "Export patch selection to a JSON file", + "exportedPatches": "Patch selection exported", + "noExportFileFound": "No patch selection to export", - "importPatchesLabel": "Import patches selection", - "importPatchesHint": "Import patches selection from a JSON file", - "importedPatches": "Patches selection imported", + "importPatchesLabel": "Import patch selection", + "importPatchesHint": "Import patch selection from a JSON file", + "importedPatches": "Patch selection imported", - "resetStoredPatchesLabel": "Reset patches", - "resetStoredPatchesHint": "Reset the stored patches selection", + "resetStoredPatchesLabel": "Reset patch selection", + "resetStoredPatchesHint": "Reset the stored patch selection", + "resetStoredPatchesDialogTitle": "Reset patch selection?", + "resetStoredPatchesDialogText": "The default selection of patches will be restored..", + "resetStoredPatches": "Patch selection has been reset", - "resetStoredOptionsLabel": "Reset options", + "resetStoredOptionsLabel": "Reset patch options", "resetStoredOptionsHint": "Reset all patch options", - - "resetStoredPatchesDialogTitle": "Reset patches selection?", - "resetStoredPatchesDialogText": "Resetting patches selection will remove all selected patches.", - "resetStoredPatches": "Patches selection has been reset", - - "resetStoredOptionsDialogTitle": "Reset options?", - "resetStoredOptionsDialogText": "Resetting options will remove all saved options.", + "resetStoredOptionsDialogTitle": "Reset patch options?", + "resetStoredOptionsDialogText": "Resetting patch options will remove all saved options.", "resetStoredOptions": "Options have been reset", - "deleteLogsLabel": "Delete logs", - "deleteLogsHint": "Delete collected manager logs", + "deleteLogsLabel": "Clear logs", + "deleteLogsHint": "Delete collected ReVanced Manager logs", "deletedLogs": "Logs deleted", "regenerateKeystoreLabel": "Regenerate keystore", - "regenerateKeystoreHint": "Regenerate the keystore used to sign the app", + "regenerateKeystoreHint": "Regenerate the keystore used to sign apps", "regenerateKeystoreDialogTitle": "Regenerate keystore?", - "regenerateKeystoreDialogText": "Patched apps signed with the old keystore will no longer be able to update.", + "regenerateKeystoreDialogText": "Patched apps signed with the old keystore will no longer be able to be updated.", "regeneratedKeystore": "Keystore regenerated", "exportKeystoreLabel": "Export keystore", - "exportKeystoreHint": "Export keystore used to sign apps", + "exportKeystoreHint": "Export the keystore used to sign apps", "exportedKeystore": "Keystore exported", "noKeystoreExportFileFound": "No keystore to export", "importKeystoreLabel": "Import keystore", - "importKeystoreHint": "Import keystore used to sign apps", + "importKeystoreHint": "Import a keystore used to sign apps", "importedKeystore": "Keystore imported", - "selectKeystorePassword": "Keystore Password", - "selectKeystorePasswordHint": "Select keystore password used to sign the apk", + "selectKeystorePassword": "Keystore password", + "selectKeystorePasswordHint": "Select keystore password used to sign apps", "jsonSelectorErrorMessage": "Unable to use selected JSON file", - "keystoreSelectorErrorMessage": "Unable to use selected KEYSTORE file" + "keystoreSelectorErrorMessage": "Unable to use selected keystore file" }, "appInfoView": { "widgetTitle": "App info", diff --git a/docs/2_4_settings.md b/docs/2_4_settings.md index 6f72fdf3..3134a7c3 100644 --- a/docs/2_4_settings.md +++ b/docs/2_4_settings.md @@ -2,37 +2,41 @@ ReVanced Manager has settings that can be configured to your liking. -## โญ Essential settings +## ๐ŸŽ›๏ธ Essential settings -- ### ๐Ÿ”— API URL +- ### ๐Ÿช› Allow changing patch selection - API to use to fetch updates and ReVanced Patches from. + Allows the user to change the patch selection from the default selection. + +- ### ๐Ÿ” Version compatibility check + + Constrains patches to supported app versions. Disable this to patch any version of an app. + + > [!WARNING] + > Disabling this may cause issues if the patches are not compatible with the app version. + +- ### ๐Ÿง‘โ€๐Ÿ”ฌ Show universal patches + + Reveals patches which can be applied to any app. + + > [!WARNING] + > These patches may not work on all apps. - ### ๐Ÿงฌ Sources - Override the API and download ReVanced Patches from a different source. + Override the API and download patches from a different source. -- ### ๐Ÿงช Experimental ReVanced Patches support +- ### ๐Ÿ”— API URL - Disable checking for the version of the app when applying ReVanced Patches. - - > [!WARNING] - > This may cause issues if the ReVanced Patches are not compatible with the app version. - -- ### ๐Ÿง‘โ€๐Ÿ”ฌ Experimental universal support - - This will show or hide ReVanced Patches, which are not meant for any app in particular but apply to all apps - - > [!WARNING] - > Because the patches generalize the app, they may not work on all apps. + API to use to fetch updates and patches from. - ### ๐Ÿ’พ Imports & Exports You can import, export or reset the following settings: - ๐Ÿ”‘ Keystore - - ๐Ÿ“„ ReVanced Patches selection - - โš™๏ธ Options + - ๐Ÿ“„ Patch selection + - โš™๏ธ Patch options > [!NOTE] > This is particularly useful if you want to backup or reset your settings. @@ -45,4 +49,4 @@ ReVanced Manager has settings that can be configured to your liking. The next page will bring you back to the usage page. -Continue: [๐Ÿ› ๏ธ Usage](2_usage.md) +Continue: [๐Ÿ› ๏ธ Usage](2_usage.md) \ No newline at end of file diff --git a/fonts/custom-icons.ttf b/fonts/custom-icons.ttf new file mode 100644 index 0000000000000000000000000000000000000000..b240c33f610b8ef9d80cc9cd546c60aa21b9dc2f GIT binary patch literal 1892 zcmd^9-)kII7(I9H?#?C~BQ}_pqB4zXn%M2`W&=@bjj6F43$03;1{9&4?#}*Vc4nNN zjY;vrN5K>V1rY=v1hIF@&WdT^ih{U( zcI4qGQbYPM7H+FybAKim_f+gD$OvTqW@TUOBF%%Z8>(VE$t?CTFBpM=bR094yV~>h zb2TjY(NF5}B6E3@F1i{j<0NafH*Xrqvokueu6>>*tGx4^nI-uYredFz;``WV-pNQ? zY3~tIXIk+jZSF@&Z``i2FNIRPrR|YLPE^F^R zC^M$9WM<@B^2y9SnLocwrwMY|!MVXhrEFF{Joq%7{#e{sHgh?1@P~@(5Ps0{0TtRw ztO8@S5^TW4n#Pj+3mT`09gWlcbG)o^hWx7e4^g2)CkYn!B-j!91&|8 z8yFXDjV1XljZ?(C8mBQSZfTq$|Aoe**bv`ooWqQfU-5(Ou+?Zr*6hlhRW6kmtZUnr zPpakFu4VV4rXO~#WvlM?qR0tbRo^RA{Z8Jh`(EU@uCJ_%+m%E<8w6`kqvzV;Fg1)f zoUq&SJ!`&D8m3nr&k60wsj1_;n~ic5)vbEycdUv&#|lEf?Np;eGm3)K#p3Y!Sb>iK z+X&G@15HG*FiUohbD960G8Txg(Zix=;?;r&8!j0eJ+5fRN|*LBd!346Bi^6#uTu3; zi02N!eC44SrMrCmf3%A{rSh-UXBk_-_rqaqJt{VLJjm-Hej|>f%ShCz7Up?g>A+o9 z>FvcU>^Q<2S0veYvB@aPac1>6i;z2Zh$?sGV=-o>wYg7~{)M=%5!ury@;NAfe!p>3 f|NsALhA@Q0MCfeVUe&3ca{Y#Xs@t>!C-(je$-Not literal 0 HcmV?d00001 diff --git a/lib/services/manager_api.dart b/lib/services/manager_api.dart index 5636778d..ad306761 100644 --- a/lib/services/manager_api.dart +++ b/lib/services/manager_api.dart @@ -244,12 +244,12 @@ class ManagerAPI { await _prefs.setBool('universalPatchesEnabled', value); } - bool areExperimentalPatchesEnabled() { - return _prefs.getBool('experimentalPatchesEnabled') ?? false; + bool isVersionCompatibilityCheckEnabled() { + return _prefs.getBool('versionCompatibilityCheckEnabled') ?? true; } - Future enableExperimentalPatchesStatus(bool value) async { - await _prefs.setBool('experimentalPatchesEnabled', value); + Future enableVersionCompatibilityCheckStatus(bool value) async { + await _prefs.setBool('versionCompatibilityCheckEnabled', value); } Future setKeystorePassword(String password) async { @@ -677,7 +677,7 @@ class ManagerAPI { Future> getDefaultPatches() async { final List patches = await getPatches(); final List defaultPatches = []; - if (areExperimentalPatchesEnabled() == false) { + if (isVersionCompatibilityCheckEnabled() == false) { defaultPatches.addAll( patches .where( diff --git a/lib/ui/views/installer/installer_viewmodel.dart b/lib/ui/views/installer/installer_viewmodel.dart index 054002ff..05cbfda3 100644 --- a/lib/ui/views/installer/installer_viewmodel.dart +++ b/lib/ui/views/installer/installer_viewmodel.dart @@ -198,9 +198,9 @@ class InstallerViewModel extends BaseViewModel { 'Patches: ${_patches.map((p) => p.name).toList().join(", ")}', '\n~ Settings', - 'Enabled changing patches: ${_managerAPI.isPatchesChangeEnabled()}', - 'Enabled universal patches: ${_managerAPI.areUniversalPatchesEnabled()}', - 'Enabled experimental patches: ${_managerAPI.areExperimentalPatchesEnabled()}', + 'Allow changing patch selection: ${_managerAPI.isPatchesChangeEnabled()}', + 'Show universal patches: ${_managerAPI.areUniversalPatchesEnabled()}', + 'Version compatibility check: ${_managerAPI.isVersionCompatibilityCheckEnabled()}', 'Patches source: ${_managerAPI.getPatchesRepo()}', 'Integration source: ${_managerAPI.getIntegrationsRepo()}', diff --git a/lib/ui/views/patcher/patcher_viewmodel.dart b/lib/ui/views/patcher/patcher_viewmodel.dart index e57accef..ec7d8128 100644 --- a/lib/ui/views/patcher/patcher_viewmodel.dart +++ b/lib/ui/views/patcher/patcher_viewmodel.dart @@ -190,7 +190,7 @@ class PatcherViewModel extends BaseViewModel { this.selectedPatches.clear(); this.selectedPatches.addAll(patches.where((patch) => !patch.excluded)); } - if (!_managerAPI.areExperimentalPatchesEnabled()) { + if (!_managerAPI.isVersionCompatibilityCheckEnabled()) { this.selectedPatches.removeWhere((patch) => !isPatchSupported(patch)); } if (!_managerAPI.areUniversalPatchesEnabled()) { diff --git a/lib/ui/views/patches_selector/patches_selector_viewmodel.dart b/lib/ui/views/patches_selector/patches_selector_viewmodel.dart index bfd64c3d..6719cdce 100644 --- a/lib/ui/views/patches_selector/patches_selector_viewmodel.dart +++ b/lib/ui/views/patches_selector/patches_selector_viewmodel.dart @@ -169,7 +169,7 @@ class PatchesSelectorViewModel extends BaseViewModel { .where( (element) => !element.excluded && - (_managerAPI.areExperimentalPatchesEnabled() || + (_managerAPI.isVersionCompatibilityCheckEnabled() || isPatchSupported(element)), ), ); @@ -281,7 +281,7 @@ class PatchesSelectorViewModel extends BaseViewModel { this.selectedPatches.addAll( patches.where((patch) => selectedPatches.contains(patch.name)), ); - if (!_managerAPI.areExperimentalPatchesEnabled()) { + if (!_managerAPI.isVersionCompatibilityCheckEnabled()) { this.selectedPatches.removeWhere((patch) => !isPatchSupported(patch)); } } else { diff --git a/lib/ui/views/settings/settings_view.dart b/lib/ui/views/settings/settings_view.dart index a806ee55..fb623440 100644 --- a/lib/ui/views/settings/settings_view.dart +++ b/lib/ui/views/settings/settings_view.dart @@ -6,8 +6,8 @@ import 'package:google_fonts/google_fonts.dart'; import 'package:revanced_manager/ui/views/settings/settingsFragment/settings_update_theme.dart'; import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_advanced_section.dart'; +import 'package:revanced_manager/ui/widgets/settingsView/settings_debug_section.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_export_section.dart'; -import 'package:revanced_manager/ui/widgets/settingsView/settings_info_section.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_team_section.dart'; import 'package:revanced_manager/ui/widgets/shared/custom_sliver_app_bar.dart'; import 'package:stacked/stacked.dart'; @@ -46,15 +46,16 @@ class SettingsView extends StatelessWidget { physics: NeverScrollableScrollPhysics(), children: const [ SUpdateThemeUI(), - // SUpdateLanguageUI(), // _settingsDivider, - STeamSection(), + // SUpdateLanguageUI(), _settingsDivider, SAdvancedSection(), _settingsDivider, SExportSection(), _settingsDivider, - SInfoSection(), + STeamSection(), + _settingsDivider, + SDebugSection(), ], ), ], diff --git a/lib/ui/views/settings/settings_viewmodel.dart b/lib/ui/views/settings/settings_viewmodel.dart index 7ae8bdb5..409d44ce 100644 --- a/lib/ui/views/settings/settings_viewmodel.dart +++ b/lib/ui/views/settings/settings_viewmodel.dart @@ -135,12 +135,12 @@ class SettingsViewModel extends BaseViewModel { notifyListeners(); } - bool areExperimentalPatchesEnabled() { - return _managerAPI.areExperimentalPatchesEnabled(); + bool isVersionCompatibilityCheckEnabled() { + return _managerAPI.isVersionCompatibilityCheckEnabled(); } - void useExperimentalPatches(bool value) { - _managerAPI.enableExperimentalPatchesStatus(value); + void useVersionCompatibilityCheck(bool value) { + _managerAPI.enableVersionCompatibilityCheckStatus(value); notifyListeners(); } diff --git a/lib/ui/widgets/homeView/latest_commit_card.dart b/lib/ui/widgets/homeView/latest_commit_card.dart index 2d62286f..cb263e25 100644 --- a/lib/ui/widgets/homeView/latest_commit_card.dart +++ b/lib/ui/widgets/homeView/latest_commit_card.dart @@ -75,7 +75,7 @@ class _LatestCommitCardState extends State { const SizedBox(height: 16), - // ReVanced Patches + // Patches CustomCard( child: Row( mainAxisAlignment: MainAxisAlignment.spaceBetween, @@ -84,7 +84,7 @@ class _LatestCommitCardState extends State { child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: [ - const Text('ReVanced Patches'), + const Text('Patches'), const SizedBox(height: 4), Row( children: [ diff --git a/lib/ui/widgets/patchesSelectorView/patch_item.dart b/lib/ui/widgets/patchesSelectorView/patch_item.dart index 74ccd96b..c5ff5974 100644 --- a/lib/ui/widgets/patchesSelectorView/patch_item.dart +++ b/lib/ui/widgets/patchesSelectorView/patch_item.dart @@ -48,13 +48,12 @@ class _PatchItemState extends State { Widget build(BuildContext context) { widget.isSelected = widget.isSelected && (!widget.isUnsupported || - widget._managerAPI.areExperimentalPatchesEnabled()) && - !widget.hasUnsupportedPatchOption; + widget._managerAPI.isVersionCompatibilityCheckEnabled()) && !widget.hasUnsupportedPatchOption; return Padding( padding: const EdgeInsets.symmetric(vertical: 4.0), child: Opacity( opacity: widget.isUnsupported && - widget._managerAPI.areExperimentalPatchesEnabled() == false + widget._managerAPI.isVersionCompatibilityCheckEnabled() == false ? 0.5 : 1, child: CustomCard( @@ -66,7 +65,7 @@ class _PatchItemState extends State { ), onTap: () { if (widget.isUnsupported && - !widget._managerAPI.areExperimentalPatchesEnabled()) { + !widget._managerAPI.isVersionCompatibilityCheckEnabled()) { widget.isSelected = false; widget.toast.showBottom('patchItem.unsupportedPatchVersion'); } else if (widget.isChangeEnabled) { @@ -80,7 +79,7 @@ class _PatchItemState extends State { setState(() {}); } if (!widget.isUnsupported || - widget._managerAPI.areExperimentalPatchesEnabled()) { + widget._managerAPI.isVersionCompatibilityCheckEnabled()) { widget.onChanged(widget.isSelected); } }, @@ -99,7 +98,7 @@ class _PatchItemState extends State { ), onChanged: (newValue) { if (widget.isUnsupported && - !widget._managerAPI.areExperimentalPatchesEnabled()) { + !widget._managerAPI.isVersionCompatibilityCheckEnabled()) { widget.isSelected = false; widget.toast.showBottom( 'patchItem.unsupportedPatchVersion', @@ -115,7 +114,7 @@ class _PatchItemState extends State { setState(() {}); } if (!widget.isUnsupported || - widget._managerAPI.areExperimentalPatchesEnabled()) { + widget._managerAPI.isVersionCompatibilityCheckEnabled()) { widget.onChanged(widget.isSelected); } }, @@ -156,7 +155,7 @@ class _PatchItemState extends State { children: [ if (widget.isUnsupported && widget._managerAPI - .areExperimentalPatchesEnabled()) + .isVersionCompatibilityCheckEnabled()) Padding( padding: const EdgeInsets.only(top: 8), child: TextButton.icon( diff --git a/lib/ui/widgets/settingsView/settings_advanced_section.dart b/lib/ui/widgets/settingsView/settings_advanced_section.dart index f3e838a6..8adce157 100644 --- a/lib/ui/widgets/settingsView/settings_advanced_section.dart +++ b/lib/ui/widgets/settingsView/settings_advanced_section.dart @@ -1,18 +1,14 @@ // ignore_for_file: prefer_const_constructors import 'package:flutter/material.dart'; -import 'package:flutter_i18n/widgets/I18nText.dart'; import 'package:revanced_manager/ui/views/settings/settingsFragment/settings_manage_api_url.dart'; import 'package:revanced_manager/ui/views/settings/settingsFragment/settings_manage_sources.dart'; -import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_auto_update_patches.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_enable_patches_selection.dart'; -import 'package:revanced_manager/ui/widgets/settingsView/settings_experimental_patches.dart'; -import 'package:revanced_manager/ui/widgets/settingsView/settings_experimental_universal_patches.dart'; import 'package:revanced_manager/ui/widgets/settingsView/settings_section.dart'; -import 'package:revanced_manager/ui/widgets/shared/custom_material_button.dart'; +import 'package:revanced_manager/ui/widgets/settingsView/settings_universal_patches.dart'; +import 'package:revanced_manager/ui/widgets/settingsView/settings_version_compatibility_check.dart'; -final _settingsViewModel = SettingsViewModel(); class SAdvancedSection extends StatelessWidget { const SAdvancedSection({super.key}); @@ -21,85 +17,14 @@ class SAdvancedSection extends StatelessWidget { Widget build(BuildContext context) { return SettingsSection( title: 'settingsView.advancedSectionTitle', - children: [ - SManageApiUrlUI(), - SManageSourcesUI(), - // SManageKeystorePasswordUI(), + children: const [ SAutoUpdatePatches(), SEnablePatchesSelection(), - SExperimentalUniversalPatches(), - SExperimentalPatches(), - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.regenerateKeystoreLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.regenerateKeystoreHint'), - onTap: () => _showDeleteKeystoreDialog(context), - ), - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.deleteTempDirLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.deleteTempDirHint'), - onTap: () => _settingsViewModel.deleteTempDir(), - ), - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.deleteLogsLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.deleteLogsHint'), - onTap: () => _settingsViewModel.deleteLogs(), - ), + SVersionCompatibilityCheck(), + SUniversalPatches(), + SManageSourcesUI(), + SManageApiUrlUI(), ], ); } - - Future _showDeleteKeystoreDialog(context) { - return showDialog( - context: context, - builder: (context) => AlertDialog( - title: I18nText('settingsView.regenerateKeystoreDialogTitle'), - backgroundColor: Theme.of(context).colorScheme.secondaryContainer, - content: I18nText('settingsView.regenerateKeystoreDialogText'), - actions: [ - CustomMaterialButton( - isFilled: false, - label: I18nText('noButton'), - onPressed: () => Navigator.of(context).pop(), - ), - CustomMaterialButton( - label: I18nText('yesButton'), - onPressed: () => { - Navigator.of(context).pop(), - _settingsViewModel.deleteKeystore(), - }, - ), - ], - ), - ); - } } diff --git a/lib/ui/widgets/settingsView/settings_debug_section.dart b/lib/ui/widgets/settingsView/settings_debug_section.dart new file mode 100644 index 00000000..7a155b4e --- /dev/null +++ b/lib/ui/widgets/settingsView/settings_debug_section.dart @@ -0,0 +1,68 @@ +import 'package:flutter/material.dart'; +import 'package:flutter_i18n/widgets/I18nText.dart'; +import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; +import 'package:revanced_manager/ui/widgets/settingsView/about_widget.dart'; +import 'package:revanced_manager/ui/widgets/settingsView/settings_section.dart'; + +final _settingsViewModel = SettingsViewModel(); + +class SDebugSection extends StatelessWidget { + const SDebugSection({super.key}); + + @override + Widget build(BuildContext context) { + return SettingsSection( + title: 'settingsView.debugSectionTitle', + children: [ + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.logsLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.logsHint'), + onTap: () => _settingsViewModel.exportLogcatLogs(), + ), + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.deleteLogsLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.deleteLogsHint'), + onTap: () => _settingsViewModel.deleteLogs(), + ), + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.deleteTempDirLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.deleteTempDirHint'), + onTap: () => _settingsViewModel.deleteTempDir(), + ), + const AboutWidget( + padding: EdgeInsets.symmetric(horizontal: 20.0), + ), + ], + ); + } +} diff --git a/lib/ui/widgets/settingsView/settings_export_section.dart b/lib/ui/widgets/settingsView/settings_export_section.dart index 786d22e7..70aaf9b0 100644 --- a/lib/ui/widgets/settingsView/settings_export_section.dart +++ b/lib/ui/widgets/settingsView/settings_export_section.dart @@ -45,42 +45,6 @@ class SExportSection extends StatelessWidget { subtitle: I18nText('settingsView.importPatchesHint'), onTap: () => _settingsViewModel.importPatches(context), ), - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.exportKeystoreLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.exportKeystoreHint'), - onTap: () => _settingsViewModel.exportKeystore(), - ), - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.importKeystoreLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.importKeystoreHint'), - onTap: () async { - await _settingsViewModel.importKeystore(); - final sManageKeystorePassword = SManageKeystorePassword(); - if (context.mounted) { - sManageKeystorePassword.showKeystoreDialog(context); - } - }, - ), ListTile( contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), title: I18nText( @@ -121,6 +85,58 @@ class SExportSection extends StatelessWidget { _settingsViewModel.resetAllOptions, ), ), + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.exportKeystoreLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.exportKeystoreHint'), + onTap: () => _settingsViewModel.exportKeystore(), + ), + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.importKeystoreLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.importKeystoreHint'), + onTap: () async { + await _settingsViewModel.importKeystore(); + final sManageKeystorePassword = SManageKeystorePassword(); + if (context.mounted) { + sManageKeystorePassword.showKeystoreDialog(context); + } + }, + ), + ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), + title: I18nText( + 'settingsView.regenerateKeystoreLabel', + child: const Text( + '', + style: TextStyle( + fontSize: 20, + fontWeight: FontWeight.w500, + ), + ), + ), + subtitle: I18nText('settingsView.regenerateKeystoreHint'), + onTap: () => _showDeleteKeystoreDialog(context), + ), + // SManageKeystorePasswordUI(), ], ); } @@ -154,4 +170,29 @@ class SExportSection extends StatelessWidget { ), ); } + + Future _showDeleteKeystoreDialog(context) { + return showDialog( + context: context, + builder: (context) => AlertDialog( + title: I18nText('settingsView.regenerateKeystoreDialogTitle'), + backgroundColor: Theme.of(context).colorScheme.secondaryContainer, + content: I18nText('settingsView.regenerateKeystoreDialogText'), + actions: [ + CustomMaterialButton( + isFilled: false, + label: I18nText('noButton'), + onPressed: () => Navigator.of(context).pop(), + ), + CustomMaterialButton( + label: I18nText('yesButton'), + onPressed: () => { + Navigator.of(context).pop(), + _settingsViewModel.deleteKeystore(), + }, + ), + ], + ), + ); + } } diff --git a/lib/ui/widgets/settingsView/settings_info_section.dart b/lib/ui/widgets/settingsView/settings_info_section.dart deleted file mode 100644 index 0a714581..00000000 --- a/lib/ui/widgets/settingsView/settings_info_section.dart +++ /dev/null @@ -1,38 +0,0 @@ -import 'package:flutter/material.dart'; -import 'package:flutter_i18n/widgets/I18nText.dart'; -import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; -import 'package:revanced_manager/ui/widgets/settingsView/about_widget.dart'; -import 'package:revanced_manager/ui/widgets/settingsView/settings_section.dart'; - -final _settingsViewModel = SettingsViewModel(); - -class SInfoSection extends StatelessWidget { - const SInfoSection({super.key}); - - @override - Widget build(BuildContext context) { - return SettingsSection( - title: 'settingsView.infoSectionTitle', - children: [ - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), - title: I18nText( - 'settingsView.logsLabel', - child: const Text( - '', - style: TextStyle( - fontSize: 20, - fontWeight: FontWeight.w500, - ), - ), - ), - subtitle: I18nText('settingsView.logsHint'), - onTap: () => _settingsViewModel.exportLogcatLogs(), - ), - const AboutWidget( - padding: EdgeInsets.symmetric(horizontal: 20.0), - ), - ], - ); - } -} diff --git a/lib/ui/widgets/settingsView/settings_experimental_universal_patches.dart b/lib/ui/widgets/settingsView/settings_universal_patches.dart similarity index 75% rename from lib/ui/widgets/settingsView/settings_experimental_universal_patches.dart rename to lib/ui/widgets/settingsView/settings_universal_patches.dart index b8a58412..1b4c27ee 100644 --- a/lib/ui/widgets/settingsView/settings_experimental_universal_patches.dart +++ b/lib/ui/widgets/settingsView/settings_universal_patches.dart @@ -4,26 +4,26 @@ import 'package:revanced_manager/ui/views/patcher/patcher_viewmodel.dart'; import 'package:revanced_manager/ui/views/patches_selector/patches_selector_viewmodel.dart'; import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; -class SExperimentalUniversalPatches extends StatefulWidget { - const SExperimentalUniversalPatches({super.key}); +class SUniversalPatches extends StatefulWidget { + const SUniversalPatches({super.key}); @override - State createState() => - _SExperimentalUniversalPatchesState(); + State createState() => + _SUniversalPatchesState(); } final _settingsViewModel = SettingsViewModel(); final _patchesSelectorViewModel = PatchesSelectorViewModel(); final _patcherViewModel = PatcherViewModel(); -class _SExperimentalUniversalPatchesState - extends State { +class _SUniversalPatchesState + extends State { @override Widget build(BuildContext context) { return SwitchListTile( contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), title: I18nText( - 'settingsView.experimentalUniversalPatchesLabel', + 'settingsView.universalPatchesLabel', child: const Text( '', style: TextStyle( @@ -32,7 +32,7 @@ class _SExperimentalUniversalPatchesState ), ), ), - subtitle: I18nText('settingsView.experimentalUniversalPatchesHint'), + subtitle: I18nText('settingsView.universalPatchesHint'), value: _settingsViewModel.areUniversalPatchesEnabled(), onChanged: (value) { setState(() { diff --git a/lib/ui/widgets/settingsView/settings_experimental_patches.dart b/lib/ui/widgets/settingsView/settings_version_compatibility_check.dart similarity index 69% rename from lib/ui/widgets/settingsView/settings_experimental_patches.dart rename to lib/ui/widgets/settingsView/settings_version_compatibility_check.dart index be704c73..ead3b070 100644 --- a/lib/ui/widgets/settingsView/settings_experimental_patches.dart +++ b/lib/ui/widgets/settingsView/settings_version_compatibility_check.dart @@ -5,24 +5,24 @@ import 'package:revanced_manager/ui/views/patches_selector/patches_selector_view import 'package:revanced_manager/ui/views/settings/settings_viewmodel.dart'; import 'package:revanced_manager/utils/check_for_supported_patch.dart'; -class SExperimentalPatches extends StatefulWidget { - const SExperimentalPatches({super.key}); +class SVersionCompatibilityCheck extends StatefulWidget { + const SVersionCompatibilityCheck({super.key}); @override - State createState() => _SExperimentalPatchesState(); + State createState() => _SVersionCompatibilityCheckState(); } final _settingsViewModel = SettingsViewModel(); final _patchesSelectorViewModel = PatchesSelectorViewModel(); final _patcherViewModel = PatcherViewModel(); -class _SExperimentalPatchesState extends State { +class _SVersionCompatibilityCheckState extends State { @override Widget build(BuildContext context) { return SwitchListTile( contentPadding: const EdgeInsets.symmetric(horizontal: 20.0), title: I18nText( - 'settingsView.experimentalPatchesLabel', + 'settingsView.versionCompatibilityCheckLabel', child: const Text( '', style: TextStyle( @@ -31,11 +31,11 @@ class _SExperimentalPatchesState extends State { ), ), ), - subtitle: I18nText('settingsView.experimentalPatchesHint'), - value: _settingsViewModel.areExperimentalPatchesEnabled(), + subtitle: I18nText('settingsView.versionCompatibilityCheckHint'), + value: _settingsViewModel.isVersionCompatibilityCheckEnabled(), onChanged: (value) { setState(() { - _settingsViewModel.useExperimentalPatches(value); + _settingsViewModel.useVersionCompatibilityCheck(value); }); if (!value) { _patcherViewModel.selectedPatches diff --git a/lib/ui/widgets/settingsView/social_media_widget.dart b/lib/ui/widgets/settingsView/social_media_widget.dart index 7cc686f1..e64f54aa 100644 --- a/lib/ui/widgets/settingsView/social_media_widget.dart +++ b/lib/ui/widgets/settingsView/social_media_widget.dart @@ -4,6 +4,7 @@ import 'package:flutter_i18n/flutter_i18n.dart'; import 'package:font_awesome_flutter/font_awesome_flutter.dart'; import 'package:revanced_manager/ui/widgets/settingsView/social_media_item.dart'; import 'package:revanced_manager/ui/widgets/shared/custom_card.dart'; +import 'package:revanced_manager/ui/widgets/shared/custom_icon.dart'; class SocialMediaWidget extends StatelessWidget { const SocialMediaWidget({ @@ -42,6 +43,12 @@ class SocialMediaWidget extends StatelessWidget { child: const CustomCard( child: Column( children: [ + SocialMediaItem( + icon: Icon(CustomIcon.revancedIcon), + title: Text('Website'), + subtitle: Text('revanced.app'), + url: 'https://revanced.app', + ), SocialMediaItem( icon: FaIcon(FontAwesomeIcons.github), title: Text('GitHub'), diff --git a/lib/ui/widgets/shared/custom_icon.dart b/lib/ui/widgets/shared/custom_icon.dart new file mode 100644 index 00000000..385b0669 --- /dev/null +++ b/lib/ui/widgets/shared/custom_icon.dart @@ -0,0 +1,9 @@ +import 'package:flutter/widgets.dart'; + +class CustomIcon { + CustomIcon._(); + + static const _kFontFam = 'CustomIcon'; + + static const IconData revancedIcon = IconData(0xe800, fontFamily: _kFontFam); +} diff --git a/pubspec.yaml b/pubspec.yaml index 749d05c4..a15fadf6 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -91,5 +91,9 @@ dev_dependencies: flutter: uses-material-design: true + fonts: + - family: CustomIcon + fonts: + - asset: fonts/custom-icons.ttf assets: - assets/i18n/