From 3ea84cf0ce23d37a1787663834ab9922f10577f8 Mon Sep 17 00:00:00 2001 From: Ivan Iskandar <12537387+ivaniskandar@users.noreply.github.com> Date: Sat, 28 Aug 2021 23:06:29 +0700 Subject: [PATCH] Add IME_FLAG_NO_PERSONALIZED_LEARNING flag to text input when incognito is enabled (#5801) * Add IME_FLAG_NO_PERSONALIZED_LEARNING flag to text input when incognito is enabled Tested with Gboard only. * Revert "Add IME_FLAG_NO_PERSONALIZED_LEARNING flag to text input when incognito is enabled" This reverts commit 068399db * Add IME_FLAG_NO_PERSONALIZED_LEARNING flag to text inputs when incognito is enabled Source preference is not affected. * Source preference stuff --- .../details/SourcePreferencesController.kt | 8 +++ .../tachiyomi/widget/TachiyomiSearchView.kt | 47 +++++++++++++++ .../widget/TachiyomiTextInputEditText.kt | 60 +++++++++++++++++++ .../main/res/layout/dialog_stub_textinput.xml | 2 +- .../res/layout/download_custom_amount.xml | 2 +- .../main/res/layout/navigation_view_text.xml | 2 +- .../main/res/layout/pref_account_login.xml | 4 +- .../main/res/layout/track_search_dialog.xml | 2 +- app/src/main/res/menu/browse_extensions.xml | 2 +- app/src/main/res/menu/browse_sources.xml | 2 +- app/src/main/res/menu/global_search.xml | 2 +- app/src/main/res/menu/history.xml | 2 +- app/src/main/res/menu/library.xml | 2 +- app/src/main/res/menu/settings_main.xml | 2 +- app/src/main/res/menu/source_browse.xml | 2 +- 15 files changed, 128 insertions(+), 13 deletions(-) create mode 100644 app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiSearchView.kt create mode 100644 app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiTextInputEditText.kt diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/SourcePreferencesController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/SourcePreferencesController.kt index d68f09e887..d804e96587 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/SourcePreferencesController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/details/SourcePreferencesController.kt @@ -27,6 +27,7 @@ import eu.kanade.tachiyomi.source.ConfigurableSource import eu.kanade.tachiyomi.source.Source import eu.kanade.tachiyomi.source.getPreferenceKey import eu.kanade.tachiyomi.ui.base.controller.NucleusController +import eu.kanade.tachiyomi.widget.TachiyomiTextInputEditText.Companion.setIncognito import timber.log.Timber @SuppressLint("RestrictedApi") @@ -113,6 +114,13 @@ class SourcePreferencesController(bundle: Bundle? = null) : pref.isIconSpaceReserved = false pref.order = Int.MAX_VALUE // reset to default order + // Apply incognito IME for EditTextPreference + if (pref is EditTextPreference) { + pref.setOnBindEditTextListener { + it.setIncognito(viewScope) + } + } + newScreen.removePreference(pref) screen.addPreference(pref) } diff --git a/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiSearchView.kt b/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiSearchView.kt new file mode 100644 index 0000000000..80e7850c60 --- /dev/null +++ b/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiSearchView.kt @@ -0,0 +1,47 @@ +package eu.kanade.tachiyomi.widget + +import android.content.Context +import android.util.AttributeSet +import androidx.appcompat.widget.SearchView +import androidx.core.view.inputmethod.EditorInfoCompat +import eu.kanade.tachiyomi.R +import eu.kanade.tachiyomi.data.preference.PreferencesHelper +import eu.kanade.tachiyomi.data.preference.asImmediateFlow +import kotlinx.coroutines.CoroutineScope +import kotlinx.coroutines.Dispatchers +import kotlinx.coroutines.SupervisorJob +import kotlinx.coroutines.cancel +import kotlinx.coroutines.flow.launchIn +import uy.kohesive.injekt.Injekt +import uy.kohesive.injekt.api.get + +/** + * A custom [SearchView] that sets [EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING] to imeOptions + * if [PreferencesHelper.incognitoMode] is true. Some IMEs may not respect this flag. + */ +class TachiyomiSearchView @JvmOverloads constructor( + context: Context, + attrs: AttributeSet? = null, + defStyleAttr: Int = R.attr.searchViewStyle +) : SearchView(context, attrs, defStyleAttr) { + + private var scope: CoroutineScope? = null + + override fun onAttachedToWindow() { + super.onAttachedToWindow() + scope = CoroutineScope(SupervisorJob() + Dispatchers.Main) + Injekt.get().incognitoMode().asImmediateFlow { + imeOptions = if (it) { + imeOptions or EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING + } else { + imeOptions and EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING.inv() + } + }.launchIn(scope!!) + } + + override fun onDetachedFromWindow() { + super.onDetachedFromWindow() + scope?.cancel() + scope = null + } +} diff --git a/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiTextInputEditText.kt b/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiTextInputEditText.kt new file mode 100644 index 0000000000..5e1ebc7f58 --- /dev/null +++ b/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiTextInputEditText.kt @@ -0,0 +1,60 @@ +package eu.kanade.tachiyomi.widget + +import android.content.Context +import android.util.AttributeSet +import android.widget.EditText +import androidx.core.view.inputmethod.EditorInfoCompat +import com.google.android.material.textfield.TextInputEditText +import eu.kanade.tachiyomi.R +import eu.kanade.tachiyomi.data.preference.PreferencesHelper +import eu.kanade.tachiyomi.data.preference.asImmediateFlow +import kotlinx.coroutines.CoroutineScope +import kotlinx.coroutines.Dispatchers +import kotlinx.coroutines.SupervisorJob +import kotlinx.coroutines.cancel +import kotlinx.coroutines.flow.launchIn +import uy.kohesive.injekt.Injekt +import uy.kohesive.injekt.api.get + +/** + * A custom [TextInputEditText] that sets [EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING] to imeOptions + * if [PreferencesHelper.incognitoMode] is true. Some IMEs may not respect this flag. + * + * @see setIncognito + */ +class TachiyomiTextInputEditText @JvmOverloads constructor( + context: Context, + attrs: AttributeSet? = null, + defStyleAttr: Int = R.attr.editTextStyle +) : TextInputEditText(context, attrs, defStyleAttr) { + + private var scope: CoroutineScope? = null + + override fun onAttachedToWindow() { + super.onAttachedToWindow() + scope = CoroutineScope(SupervisorJob() + Dispatchers.Main) + setIncognito(scope!!) + } + + override fun onDetachedFromWindow() { + super.onDetachedFromWindow() + scope?.cancel() + scope = null + } + + companion object { + /** + * Sets Flow to this [EditText] that sets [EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING] to imeOptions + * if [PreferencesHelper.incognitoMode] is true. Some IMEs may not respect this flag. + */ + fun EditText.setIncognito(viewScope: CoroutineScope) { + Injekt.get().incognitoMode().asImmediateFlow { + imeOptions = if (it) { + imeOptions or EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING + } else { + imeOptions and EditorInfoCompat.IME_FLAG_NO_PERSONALIZED_LEARNING.inv() + } + }.launchIn(viewScope) + } + } +} diff --git a/app/src/main/res/layout/dialog_stub_textinput.xml b/app/src/main/res/layout/dialog_stub_textinput.xml index 1a4b99e619..4bbc29d20c 100644 --- a/app/src/main/res/layout/dialog_stub_textinput.xml +++ b/app/src/main/res/layout/dialog_stub_textinput.xml @@ -11,7 +11,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> - diff --git a/app/src/main/res/layout/download_custom_amount.xml b/app/src/main/res/layout/download_custom_amount.xml index 384052130a..a38b546816 100644 --- a/app/src/main/res/layout/download_custom_amount.xml +++ b/app/src/main/res/layout/download_custom_amount.xml @@ -25,7 +25,7 @@ android:tint="?attr/colorAccent" app:srcCompat="@drawable/ic_chevron_left_black_24dp" /> - - - - - diff --git a/app/src/main/res/menu/browse_sources.xml b/app/src/main/res/menu/browse_sources.xml index 51767187bf..3717488773 100644 --- a/app/src/main/res/menu/browse_sources.xml +++ b/app/src/main/res/menu/browse_sources.xml @@ -5,7 +5,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_travel_explore_24dp" android:title="@string/action_global_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="collapseActionView|ifRoom" /> diff --git a/app/src/main/res/menu/global_search.xml b/app/src/main/res/menu/global_search.xml index efbd32c55a..743391d807 100644 --- a/app/src/main/res/menu/global_search.xml +++ b/app/src/main/res/menu/global_search.xml @@ -5,7 +5,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_search_24dp" android:title="@string/action_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="collapseActionView|ifRoom" /> diff --git a/app/src/main/res/menu/history.xml b/app/src/main/res/menu/history.xml index 426bc8889f..bc04d8389c 100644 --- a/app/src/main/res/menu/history.xml +++ b/app/src/main/res/menu/history.xml @@ -6,7 +6,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_search_24dp" android:title="@string/action_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="ifRoom|collapseActionView" /> diff --git a/app/src/main/res/menu/library.xml b/app/src/main/res/menu/library.xml index 5d45e24926..99f38a5bad 100644 --- a/app/src/main/res/menu/library.xml +++ b/app/src/main/res/menu/library.xml @@ -7,7 +7,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_search_24dp" android:title="@string/action_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="collapseActionView|ifRoom" /> diff --git a/app/src/main/res/menu/settings_main.xml b/app/src/main/res/menu/settings_main.xml index efbd32c55a..743391d807 100644 --- a/app/src/main/res/menu/settings_main.xml +++ b/app/src/main/res/menu/settings_main.xml @@ -5,7 +5,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_search_24dp" android:title="@string/action_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="collapseActionView|ifRoom" /> diff --git a/app/src/main/res/menu/source_browse.xml b/app/src/main/res/menu/source_browse.xml index 9c50d54007..0519ac7dd6 100644 --- a/app/src/main/res/menu/source_browse.xml +++ b/app/src/main/res/menu/source_browse.xml @@ -5,7 +5,7 @@ android:id="@+id/action_search" android:icon="@drawable/ic_search_24dp" android:title="@string/action_search" - app:actionViewClass="androidx.appcompat.widget.SearchView" + app:actionViewClass="eu.kanade.tachiyomi.widget.TachiyomiSearchView" app:iconTint="?attr/colorOnToolbar" app:showAsAction="collapseActionView|ifRoom" />