From e388f0d563ec6949308f6f3b272671047cf3e3ca Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Sat, 18 Apr 2020 11:59:22 -0400
Subject: [PATCH] Round manga info cover

---
 .../main/res/layout/manga_info_controller.xml | 36 +++++++++++--------
 app/src/main/res/layout/source_grid_item.xml  |  2 +-
 app/src/main/res/values/dimens.xml            |  1 +
 3 files changed, 24 insertions(+), 15 deletions(-)

diff --git a/app/src/main/res/layout/manga_info_controller.xml b/app/src/main/res/layout/manga_info_controller.xml
index dfbbc289dd..c612d94ef0 100644
--- a/app/src/main/res/layout/manga_info_controller.xml
+++ b/app/src/main/res/layout/manga_info_controller.xml
@@ -20,7 +20,7 @@
                 android:layout_width="0dp"
                 android:layout_height="0dp"
                 android:layout_marginTop="16dp"
-                app:layout_constraintTop_toBottomOf="@+id/manga_cover" />
+                app:layout_constraintTop_toBottomOf="@+id/manga_cover_card" />
 
             <androidx.constraintlayout.widget.Guideline
                 android:id="@+id/guideline2"
@@ -40,20 +40,28 @@
                 app:layout_constraintTop_toTopOf="parent"
                 tools:background="@color/material_grey_700" />
 
-            <ImageView
-                android:id="@+id/manga_cover"
+            <androidx.cardview.widget.CardView
+                android:id="@+id/manga_cover_card"
                 android:layout_width="0dp"
                 android:layout_height="0dp"
                 android:layout_marginStart="16dp"
                 android:layout_marginTop="16dp"
                 android:layout_marginEnd="16dp"
                 android:layout_marginBottom="16dp"
-                android:contentDescription="@string/description_cover"
+                app:cardCornerRadius="@dimen/card_radius"
                 app:layout_constraintDimensionRatio="h,2:3"
                 app:layout_constraintEnd_toStartOf="@+id/guideline2"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toTopOf="parent"
-                tools:background="@color/material_grey_700" />
+                app:layout_constraintTop_toTopOf="parent">
+
+                <ImageView
+                    android:id="@+id/manga_cover"
+                    android:layout_width="match_parent"
+                    android:layout_height="match_parent"
+                    android:contentDescription="@string/description_cover"
+                    tools:background="@color/material_grey_700" />
+
+            </androidx.cardview.widget.CardView>
 
             <androidx.constraintlayout.widget.ConstraintLayout
                 android:layout_width="0dp"
@@ -195,14 +203,14 @@
                     android:text="@string/add_to_library"
                     app:icon="@drawable/ic_add_to_library_24dp" />
 
-<!--                <com.google.android.material.button.MaterialButton-->
-<!--                    android:id="@+id/btn_tracking"-->
-<!--                    style="@style/Theme.Widget.Button.Icon"-->
-<!--                    android:layout_width="wrap_content"-->
-<!--                    android:layout_height="wrap_content"-->
-<!--                    android:layout_marginStart="8dp"-->
-<!--                    android:text="@string/manga_tracking_tab"-->
-<!--                    app:icon="@drawable/ic_sync_24dp" />-->
+                <!--                <com.google.android.material.button.MaterialButton-->
+                <!--                    android:id="@+id/btn_tracking"-->
+                <!--                    style="@style/Theme.Widget.Button.Icon"-->
+                <!--                    android:layout_width="wrap_content"-->
+                <!--                    android:layout_height="wrap_content"-->
+                <!--                    android:layout_marginStart="8dp"-->
+                <!--                    android:text="@string/manga_tracking_tab"-->
+                <!--                    app:icon="@drawable/ic_sync_24dp" />-->
 
                 <com.google.android.material.button.MaterialButton
                     android:id="@+id/btn_share"
diff --git a/app/src/main/res/layout/source_grid_item.xml b/app/src/main/res/layout/source_grid_item.xml
index bc2d9a08c8..db62e9e42a 100644
--- a/app/src/main/res/layout/source_grid_item.xml
+++ b/app/src/main/res/layout/source_grid_item.xml
@@ -11,7 +11,7 @@
         android:id="@+id/card"
         android:layout_width="wrap_content"
         android:layout_height="220dp"
-        app:cardCornerRadius="4dp">
+        app:cardCornerRadius="@dimen/card_radius">
 
         <ImageView
             android:id="@+id/thumbnail"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index ab16c0f412..ada419e74a 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -7,6 +7,7 @@
     <dimen name="margin_left">16dp</dimen>
     <dimen name="margin_right">16dp</dimen>
     <dimen name="space_between_cards">4dp</dimen>
+    <dimen name="card_radius">4dp</dimen>
 
     <dimen name="fab_size">56dp</dimen>
     <dimen name="fab_margin">16dp</dimen>