From 0627fcfb62ba3229cacc2b41a4f30892a46a6229 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Fri, 31 Jan 2020 13:48:17 -0500 Subject: [PATCH] Fix broken row rendering for non-network-based URL Reported internally by volunteers. Regression from: - https://github.com/gorhill/uBlock/commit/3a564c199260#diff-fd76b4e8f9d7bfb2e5e01510c9457633L367 --- src/js/logger-ui.js | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/js/logger-ui.js b/src/js/logger-ui.js index 99b46ad5d..9f98c98cf 100644 --- a/src/js/logger-ui.js +++ b/src/js/logger-ui.js @@ -376,29 +376,30 @@ const parseLogEntry = function(details) { // Cell 3 textContent.push(normalizeToStr(entry.docHostname)); - // Cell 4 - if ( entry.realm === 'network' ) { - // partyness - if ( typeof entry.domain === 'string' && entry.domain !== '' ) { - let partyness = ''; - if ( entry.tabDomain !== undefined ) { - if ( entry.tabId < 0 ) { - partyness += '0,'; - } - partyness += entry.domain === entry.tabDomain ? '1' : '3'; + // Cell 4: partyness + if ( + entry.realm === 'network' && + typeof entry.domain === 'string' && + entry.domain !== '' + ) { + let partyness = ''; + if ( entry.tabDomain !== undefined ) { + if ( entry.tabId < 0 ) { + partyness += '0,'; + } + partyness += entry.domain === entry.tabDomain ? '1' : '3'; + } else { + partyness += '?'; + } + if ( entry.docDomain !== entry.tabDomain ) { + partyness += ','; + if ( entry.docDomain !== undefined ) { + partyness += entry.domain === entry.docDomain ? '1' : '3'; } else { partyness += '?'; } - if ( entry.docDomain !== entry.tabDomain ) { - partyness += ','; - if ( entry.docDomain !== undefined ) { - partyness += entry.domain === entry.docDomain ? '1' : '3'; - } else { - partyness += '?'; - } - } - textContent.push(partyness); } + textContent.push(partyness); } else { textContent.push(''); }