code review: fix rtl rendering of 3rd-party filters pane

This commit is contained in:
gorhill 2017-01-24 13:53:04 -05:00
parent 1a075bc673
commit 0e11d6e95e
3 changed files with 14 additions and 14 deletions

View file

@ -43,15 +43,15 @@
</li> </li>
<li class="listEntry"> <li class="listEntry">
<input type="checkbox"><!-- <input type="checkbox"><!--
--><a class="content" type="text/plain" target="_blank" href=""></a><!-- --><a class="content" type="text/plain" target="_blank" href=""></a>&#8203;<!--
--><a class="fa support" href="" target="_blank">&#xf015;</a><!-- --><a class="fa support" href="" target="_blank">&#xf015;</a>&#8203;<!--
--><a class="fa remove" href="">&#xf00d;</a><!-- --><a class="fa remove" href="">&#xf00d;</a>&#8203;<!--
--><a class="fa mustread" href="" target="_blank">&#xf05a;</a><!-- --><a class="fa mustread" href="" target="_blank">&#xf05a;</a>&#8203;<!--
--><span class="fa status unsecure" title="http">&#xf13e;</span><!-- --><span class="fa status unsecure" title="http">&#xf13e;</span>&#8203;<!--
--><span class="counts dim"></span><!-- --><span class="counts dim"></span>&#8203;<!--
--><span class="fa status obsolete" title="3pExternalListObsolete">&#xf071;</span><!-- --><span class="fa status obsolete" title="3pExternalListObsolete">&#xf071;</span>&#8203;<!--
--><span class="fa status cache">&#xf017;</span><!-- --><span class="fa status cache">&#xf017;</span>&#8203;<!--
--><span class="fa status updating">&#xf110;</span><!-- --><span class="fa status updating">&#xf110;</span>&#8203;<!--
--><span class="fa status failed">&#xf06a;</span> --><span class="fa status failed">&#xf06a;</span>
</li> </li>
</ul> </ul>

View file

@ -23,7 +23,7 @@ body.hideUnused #listsOfBlockedHostsPrompt:before {
padding-left: 0.5em; padding-left: 0.5em;
padding-right: 0em; padding-right: 0em;
} }
body[dir=rtl] #lists { body[dir="rtl"] #lists {
padding-left: 0em; padding-left: 0em;
padding-right: 0.5em; padding-right: 0.5em;
} }
@ -57,12 +57,12 @@ li.listEntry {
line-height: 150%; line-height: 150%;
margin: 0 auto 0 auto; margin: 0 auto 0 auto;
margin-left: 2.5em; margin-left: 2.5em;
margin-right: 0em; margin-right: 0;
text-indent: -2em; text-indent: -2em;
} }
body[dir=rtl] li.listEntry { body[dir="rtl"] li.listEntry {
margin-left: 0em; margin-left: 0em;
margin-right: 1em; margin-right: 2.5em;
} }
li.listEntry > * { li.listEntry > * {
margin-right: 0.5em; margin-right: 0.5em;

View file

@ -91,7 +91,7 @@ var renderFilterLists = function(soft) {
elem = li.querySelector('a:nth-of-type(1)'); elem = li.querySelector('a:nth-of-type(1)');
elem.setAttribute('href', 'asset-viewer.html?url=' + encodeURI(listKey)); elem.setAttribute('href', 'asset-viewer.html?url=' + encodeURI(listKey));
elem.setAttribute('type', 'text/html'); elem.setAttribute('type', 'text/html');
elem.textContent = listNameFromListKey(listKey) + '\u200E'; elem.textContent = listNameFromListKey(listKey);
li.classList.remove('toRemove'); li.classList.remove('toRemove');
if ( entry.supportName ) { if ( entry.supportName ) {
li.classList.add('support'); li.classList.add('support');