From 182889d0dfff641ae2d6c4579ab9f64858967892 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 20 Nov 2019 06:12:57 -0500 Subject: [PATCH] Extend waiting time from 3 min to 15 min As per Mozilla blog post: - https://blog.mozilla.org/addons/2019/11/11/security-improvements-in-amo-upload-tools/ > For custom scripts that use the AMO upload API: > make sure your upload scripts account for > potentially longer delays before the signed file > is available. We recommend allowing up to 15 > minutes. --- dist/firefox/publish-signed-beta.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dist/firefox/publish-signed-beta.py b/dist/firefox/publish-signed-beta.py index 51e215155..d69388bb3 100755 --- a/dist/firefox/publish-signed-beta.py +++ b/dist/firefox/publish-signed-beta.py @@ -202,11 +202,14 @@ with open(unsigned_xpi_filepath, 'rb') as f: # Wait for signed package to be ready signing_check_url = signing_request_response['url'] # TODO: use real time instead - countdown = 180 / 5 + # https://blog.mozilla.org/addons/2019/11/11/security-improvements-in-amo-upload-tools/ + # "We recommend allowing up to 15 minutes." + interval = 30 # check every 30 seconds + countdown = 15 * 60 / interval # for at most 15 minutes while True: sys.stdout.write('.') sys.stdout.flush() - time.sleep(5) + time.sleep(interval) countdown -= 1 if countdown <= 0: print('Error: AMO signing timed out')