From 54e8761ce67d8380d6a64ae86fedf7422e29e8da Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 8 Nov 2016 16:40:15 -0500 Subject: [PATCH] code review re #2132 --- src/js/cosmetic-filtering.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/js/cosmetic-filtering.js b/src/js/cosmetic-filtering.js index bdbc9c638..def62047d 100644 --- a/src/js/cosmetic-filtering.js +++ b/src/js/cosmetic-filtering.js @@ -1424,9 +1424,11 @@ FilterContainer.prototype._lookupUserScript = function(dict, raw, reng, out) { pos = args.indexOf(','); if ( pos === -1 ) { pos = args.length; } arg = args.slice(0, pos).trim(); - if ( reArgValidator.test(arg) ) { - content = content.replace('{{' + i + '}}', arg); + // Abort on invalid arguments. + if ( reArgValidator.test(arg) === false ) { + return; } + content = content.replace('{{' + i + '}}', arg); args = args.slice(pos + 1).trim(); i++; } @@ -1436,7 +1438,7 @@ FilterContainer.prototype._lookupUserScript = function(dict, raw, reng, out) { }; // Only accept plain word characters for now. -var reArgValidator = /^\w*$/; +var reArgValidator = /^[\w\.]*$/; /******************************************************************************/