external/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-10 09:07:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

code review: avoid special WebRTC test for non-Chromium browsers (#533)

Browse source
This commit is contained in:
Raymond Hill 2018-04-06 13:25:06 -04:00
parent c0387835fa
commit 79b4706746
No known key found for this signature in database
GPG key ID: 25E1490B761470C2
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
platform/chromium/vapi-background.js
View file

@ -92,7 +92,19 @@ vAPI.browserSettings = (function() {
}
return {
webRTCSupported: undefined,
// Whether the WebRTC-related privacy API is crashy is an open question
// only for Chromium proper (because it can be compiled without the
// WebRTC feature): hence avoid overhead of the evaluation (which uses
// an iframe) for platforms where it's a non-issue.
webRTCSupported: (function() {
var flavor = vAPI.webextFlavor.soup;
if (
flavor.has('chromium') === false ||
flavor.has('google') || flavor.has('opera')
) {
return true;
}
})(),
// https://github.com/gorhill/uBlock/issues/875
// Must not leave `lastError` unchecked.
@ -112,6 +124,10 @@ vAPI.browserSettings = (function() {
setWebrtcIPAddress: function(setting) {
// We don't know yet whether this browser supports WebRTC: find out.
if ( this.webRTCSupported === undefined ) {
// If asked to leave WebRTC setting alone at this point in the
// code, this means we never grabbed the setting in the first
// place.
if ( setting ) { return; }
this.webRTCSupported = { setting: setting };
var iframe = document.createElement('iframe');
var me = this;