From 84f22ce3a6afbe975b0bf8ad7a197f24bc57a4ed Mon Sep 17 00:00:00 2001 From: gorhill Date: Wed, 14 Jun 2017 08:32:12 -0400 Subject: [PATCH] code review: do not pollute logger with firewall noop rules --- src/js/pagestore.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/pagestore.js b/src/js/pagestore.js index 6b0c12a32..2d5f85a22 100644 --- a/src/js/pagestore.js +++ b/src/js/pagestore.js @@ -639,9 +639,9 @@ PageStore.prototype.filterRequest = function(context) { // Dynamic hostname/type filtering. if ( result === 0 && µb.userSettings.advancedUserEnabled ) { result = µb.sessionFirewall.evaluateCellZY( context.rootHostname, context.requestHostname, requestType); - if ( result !== 0 && µb.logger.isEnabled() ) { + if ( result !== 0 && result !== 3 && µb.logger.isEnabled() ) { this.logData = µb.sessionFirewall.toLogData(); - } + } } // Static filtering: lowest filtering precedence. @@ -732,7 +732,7 @@ PageStore.prototype.filterRequestNoCache = function(context) { // Dynamic hostname/type filtering. if ( result === 0 && µb.userSettings.advancedUserEnabled ) { result = µb.sessionFirewall.evaluateCellZY(context.rootHostname, context.requestHostname, requestType); - if ( result !== 0 && µb.logger.isEnabled() ) { + if ( result !== 0 && result !== 3 && µb.logger.isEnabled() ) { this.logData = µb.sessionFirewall.toLogData(); } }