external/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-10 17:17:57 +01:00
Code Issues Projects Releases Packages Wiki Activity

code review re. badge update

Browse source
This commit is contained in:
gorhill 2015-05-01 08:27:41 -04:00
parent 9f529bd6b0
commit ca1e1f55e7
3 changed files with 18 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/js/async.js
View file

@ -170,28 +170,34 @@ return asyncJobManager;
/******************************************************************************/
// Update visual of extension icon.
// A time out is used to coalesce adjacent requests to update badge.
µBlock.updateBadgeAsync = (function(){
µBlock.updateBadgeAsync = (function() {
var µb = µBlock;
var tabIdToTimer = {};
// Cache callback definition, it was a bad idea to define this one inside
// updateBadgeAsync
var updateBadge = function(tabId) {
delete tabIdToTimer[tabId];
var pageStore = µb.pageStoreFromTabId(tabId);
if ( pageStore ) {
pageStore.updateBadge();
if ( pageStore === null ) {
return;
}
vAPI.setIcon(tabId, 'off', '');
var netFiltering = pageStore.getNetFilteringSwitch();
var badge = '';
if ( µb.userSettings.showIconBadge && netFiltering && pageStore.perLoadBlockedRequestCount ) {
badge = µb.utils.formatCount(pageStore.perLoadBlockedRequestCount);
}
vAPI.setIcon(tabId, netFiltering ? 'on' : 'off', badge);
};
var updateBadgeAsync = function(tabId) {
return function(tabId) {
if ( vAPI.isBehindTheSceneTabId(tabId) ) {
return;
}
µb.asyncJobs.add('updateBadge-' + tabId, tabId, updateBadge, 250);
if ( tabIdToTimer.hasOwnProperty(tabId) ) {
return;
}
tabIdToTimer[tabId] = setTimeout(updateBadge.bind(null, tabId), 500);
};
return updateBadgeAsync;
})();

11
src/js/pagestore.js
View file

@ -589,17 +589,6 @@ PageStore.prototype.logRequest = function(context, result) {
µb.localSettingsModifyTime = now;
};
/******************************************************************************/
PageStore.prototype.updateBadge = function() {
var netFiltering = this.getNetFilteringSwitch();
var badge = '';
if ( µb.userSettings.showIconBadge && netFiltering && this.perLoadBlockedRequestCount ) {
badge = µb.utils.formatCount(this.perLoadBlockedRequestCount);
}
vAPI.setIcon(this.tabId, netFiltering ? 'on' : 'off', badge);
};
// https://www.youtube.com/watch?v=drW8p_dTLD4
/******************************************************************************/

2
src/js/tab.js
View file

@ -556,7 +556,7 @@ vAPI.tabs.registerListeners();
/******************************************************************************/
µb.pageStoreFromTabId = function(tabId) {
return this.pageStores[tabId];
return this.pageStores[tabId] || null;
};
/******************************************************************************/