Minor code review of scriptlets

This commit is contained in:
Raymond Hill 2023-09-22 09:33:02 -04:00
parent 3f3f383473
commit cce3f3efc1
No known key found for this signature in database
GPG key ID: 25E1490B761470C2

View file

@ -1365,9 +1365,12 @@ function jsonPruneXhrResponse(
if ( xhrDetails === undefined ) {
return innerResponse;
}
if ( xhrDetails.latestResponseLength != innerResponse.length ) {
const responseLength = typeof innerResponse === 'string'
? innerResponse.length
: undefined;
if ( xhrDetails.lastResponseLength !== responseLength ) {
xhrDetails.response = undefined;
xhrDetails.latestResponseLength = innerResponse.length;
xhrDetails.lastResponseLength = responseLength;
}
if ( xhrDetails.response !== undefined ) {
return xhrDetails.response;
@ -3694,12 +3697,18 @@ function trustedReplaceXhrResponse(
if ( xhrDetails === undefined ) {
return innerResponse;
}
if ( typeof innerResponse !== 'string' ) {
xhrDetails.response = innerResponse;
const responseLength = typeof innerResponse === 'string'
? innerResponse.length
: undefined;
if ( xhrDetails.lastResponseLength !== responseLength ) {
xhrDetails.response = undefined;
xhrDetails.lastResponseLength = responseLength;
}
let outerResponse = xhrDetails.response;
if ( outerResponse !== undefined ) {
return outerResponse;
if ( xhrDetails.response !== undefined ) {
return xhrDetails.response;
}
if ( typeof innerResponse !== 'string' ) {
return (xhrDetails.response = innerResponse);
}
const textBefore = innerResponse;
const textAfter = textBefore.replace(rePattern, replacement);
@ -3711,8 +3720,7 @@ function trustedReplaceXhrResponse(
`\n\treplacement: ${replacement}`,
);
}
xhrDetails.response = textAfter;
return textAfter;
return (xhrDetails.response = textAfter);
}
get responseText() {
const response = this.response;