From f362dff6439fbe88a21591358346139664091c51 Mon Sep 17 00:00:00 2001 From: gorhill Date: Mon, 9 Mar 2015 19:19:08 -0400 Subject: [PATCH] code review: do not pollute global namespace --- src/js/3p-filters.js | 3 ++- src/js/i18n.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/js/3p-filters.js b/src/js/3p-filters.js index 22226c5fe..452013c64 100644 --- a/src/js/3p-filters.js +++ b/src/js/3p-filters.js @@ -68,6 +68,7 @@ var renderBlacklists = function() { var listGroupTemplate = uDom('#templates .groupEntry'); var listEntryTemplate = uDom('#templates .listEntry'); var listStatsTemplate = vAPI.i18n('3pListsOfBlockedHostsPerListStats'); + var renderElapsedTimeToString = vAPI.i18n.renderElapsedTimeToString; // Assemble a pretty blacklist name if possible var listNameFromListKey = function(listKey) { @@ -129,7 +130,7 @@ var renderBlacklists = function() { if ( asset.cached ) { elem = li.descendants('span.status.purge'); elem.css('display', ''); - elem.attr('title', renderElapsedTime(asset.lastModified)); + elem.attr('title', renderElapsedTimeToString(asset.lastModified)); hasCachedContent = true; } return li; diff --git a/src/js/i18n.js b/src/js/i18n.js index 8ca47a7ff..e2e47eb8e 100644 --- a/src/js/i18n.js +++ b/src/js/i18n.js @@ -51,7 +51,7 @@ uDom.onLoad(function() { /******************************************************************************/ -var renderElapsedTime = function(tstamp) { +vAPI.i18n.renderElapsedTimeToString = function(tstamp) { var value = (Date.now() - tstamp) / 60000; if ( value < 2 ) { return vAPI.i18n('elapsedOneMinuteAgo');