From 42abc1b5722cdf60f7e85f9524c81ee53ae30ef8 Mon Sep 17 00:00:00 2001
From: GHOSCHT <31184695+GHOSCHT@users.noreply.github.com>
Date: Fri, 31 Dec 2021 21:46:45 +0100
Subject: [PATCH] Remove unnecessary code

---
 Dashboard/src/App.tsx                         | 12 +++---
 .../actions/asyncSerialConnectionActions.ts   | 43 -------------------
 .../redux/actions/serialConnectionActions.ts  | 23 ----------
 Dashboard/src/redux/store/root-reducer.ts     |  2 +-
 4 files changed, 6 insertions(+), 74 deletions(-)
 delete mode 100644 Dashboard/src/redux/actions/asyncSerialConnectionActions.ts
 delete mode 100644 Dashboard/src/redux/actions/serialConnectionActions.ts

diff --git a/Dashboard/src/App.tsx b/Dashboard/src/App.tsx
index 0bb926d..2693f1c 100644
--- a/Dashboard/src/App.tsx
+++ b/Dashboard/src/App.tsx
@@ -1,10 +1,8 @@
 import React, { useState } from "react";
 import { createGlobalStyle } from "styled-components";
-import { useDispatch } from "react-redux";
+// import { useDispatch } from "react-redux";
 import Select from "react-select";
 import SerialPort from "serialport";
-import { connect, disconnect } from "./redux/actions/asyncSerialConnectionActions";
-import { setSerialPort } from "./redux/actions/serialConnectionActions";
 import KnobSection from "./Components/KnobSection";
 
 const GlobalStyle = createGlobalStyle`
@@ -28,14 +26,14 @@ const fetchPorts = async () => {
 };
 
 const App = () => {
-  const dispatch = useDispatch();
+  // const dispatch = useDispatch();
 
   fetchPorts();
 
   const [portSelectionValue, setPortSelectionValue] = useState(options[0]);
   const handlePortChange = async (selectedOption: any) => {
     setPortSelectionValue(selectedOption);
-    dispatch(setSerialPort(selectedOption.value));
+    // dispatch(setSerialPort(selectedOption.value));
   };
 
   return (
@@ -45,7 +43,7 @@ const App = () => {
       <button
         type="button"
         onClick={() => {
-          dispatch(connect());
+          // dispatch(connect());
         }}
       >
         connect
@@ -53,7 +51,7 @@ const App = () => {
       <button
         type="button"
         onClick={() => {
-          dispatch(disconnect());
+          // dispatch(disconnect());
         }}
       >
         disconnect
diff --git a/Dashboard/src/redux/actions/asyncSerialConnectionActions.ts b/Dashboard/src/redux/actions/asyncSerialConnectionActions.ts
deleted file mode 100644
index 57a0e62..0000000
--- a/Dashboard/src/redux/actions/asyncSerialConnectionActions.ts
+++ /dev/null
@@ -1,43 +0,0 @@
-import { ThunkResult } from "typesafe-actions";
-import {
-  connectionStart, connectionSuccess, connectionFailure, setPortController, connectionEnd,
-} from "./serialConnectionActions";
-import PortController from "../../serial/PortController";
-
-const connect = (): ThunkResult<void> => async (dispatch, getState) => {
-  const state = getState();
-  dispatch(connectionStart());
-
-  if (state.serialConnection.port === null) {
-    dispatch(connectionFailure(new Error("No Serial Port set")));
-    return;
-  }
-
-  const controller = new PortController();
-  controller.create(state.serialConnection.port);
-
-  dispatch(setPortController(controller));
-
-  controller.open((error) => {
-    if (error === null || error === undefined) {
-      dispatch(connectionSuccess());
-    } else {
-      dispatch(connectionFailure(error));
-    }
-  }, (error) => {
-    if (error !== null && error !== undefined) {
-      if (error.message === "Reading from COM port (ReadIOCompletion): Access denied") {
-        dispatch(connectionFailure(new Error(`Device ${state.serialConnection.port} disconnected`)));
-        dispatch(connectionEnd());
-      }
-    }
-  });
-};
-
-const disconnect = (): ThunkResult<void> => async (dispatch, getState) => {
-  const state = getState();
-  state.serialConnection.portController?.close();
-  dispatch(connectionEnd());
-};
-
-export { connect, disconnect };
diff --git a/Dashboard/src/redux/actions/serialConnectionActions.ts b/Dashboard/src/redux/actions/serialConnectionActions.ts
deleted file mode 100644
index 8c54ac1..0000000
--- a/Dashboard/src/redux/actions/serialConnectionActions.ts
+++ /dev/null
@@ -1,23 +0,0 @@
-import { action } from "typesafe-actions";
-import PortController from "../../PortController";
-
-export enum SerialConnectionActionTypes {
-    SET_SERIAL_PORT = "SET_SERIAL_PORT",
-    CONNECTION_START = "CONNECTION_START",
-    CONNECTION_SUCCESS = "CONNECTION_SUCCESS",
-    CONNECTION_FAILURE = "CONNECTION_FAILURE",
-    CONNECTION_END = "CONNECTION_END",
-    SET_PORT_CONTROLLER = "SET_PORT_CONTROLLER"
-  }
-
-export const setSerialPort = (port: string) => action(SerialConnectionActionTypes.SET_SERIAL_PORT, port);
-
-export const connectionStart = () => action(SerialConnectionActionTypes.CONNECTION_START);
-
-export const connectionSuccess = () => action(SerialConnectionActionTypes.CONNECTION_SUCCESS);
-
-export const connectionFailure = (error: Error) => action(SerialConnectionActionTypes.CONNECTION_FAILURE, error);
-
-export const connectionEnd = () => action(SerialConnectionActionTypes.CONNECTION_END);
-
-export const setPortController = (controller: PortController) => action(SerialConnectionActionTypes.SET_PORT_CONTROLLER, controller);
diff --git a/Dashboard/src/redux/store/root-reducer.ts b/Dashboard/src/redux/store/root-reducer.ts
index d9f48c4..a170d27 100644
--- a/Dashboard/src/redux/store/root-reducer.ts
+++ b/Dashboard/src/redux/store/root-reducer.ts
@@ -1,5 +1,5 @@
 import { combineReducers } from "redux";
-import SerialConnectionReducer from "../reducers/serialConnectionReducer";
+import SerialConnectionReducer from "../slices/serialConnectionSlice";
 
 const rootReducer = combineReducers({
   serialConnection: SerialConnectionReducer,