heliox/old-monorepo
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Accept T as copy instead of referende

Browse source 
xQueueSend() copies the value, so accepting a reference is misleading
This commit is contained in:
GHOSCHT 2023-03-25 18:09:11 +01:00
parent 428a0f437f
commit 96c39d4792
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/control/Firmware/src/FreeRTOS/Queue.h
View file

@ -26,7 +26,7 @@ public:
size_t size() { return uxQueueMessagesWaiting(handle); } size_t size() { return uxQueueMessagesWaiting(handle); }
size_t available() { return uxQueueSpacesAvailable(handle); } size_t available() { return uxQueueSpacesAvailable(handle); }
size_t capacity() { return queueCapacity; } size_t capacity() { return queueCapacity; }
bool push(const T &item, const TickType_t ticksToWait = portMAX_DELAY) { bool push(const T item, const TickType_t ticksToWait = portMAX_DELAY) {
return xQueueSend(handle, &item, ticksToWait) == pdTRUE; return xQueueSend(handle, &item, ticksToWait) == pdTRUE;
} }
etl::optional<T> pop(const TickType_t ticksToWait = portMAX_DELAY) { etl::optional<T> pop(const TickType_t ticksToWait = portMAX_DELAY) {