Moved away from react-codemirror2 to interacting with codemirror directly.

This commit is contained in:
orangemug 2019-10-15 17:34:36 +01:00
parent f088788246
commit 563a78ed42

View file

@ -1,9 +1,9 @@
import React from 'react' import React from 'react'
import PropTypes from 'prop-types' import PropTypes from 'prop-types'
import {Controlled as CodeMirror} from 'react-codemirror2'
import InputBlock from '../inputs/InputBlock' import InputBlock from '../inputs/InputBlock'
import StringInput from '../inputs/StringInput' import StringInput from '../inputs/StringInput'
import CodeMirror from 'codemirror';
import 'codemirror/mode/javascript/javascript' import 'codemirror/mode/javascript/javascript'
import 'codemirror/addon/lint/lint' import 'codemirror/addon/lint/lint'
@ -25,36 +25,82 @@ class JSONEditor extends React.Component {
constructor(props) { constructor(props) {
super(props) super(props)
this.state = { this.state = {
code: JSON.stringify(props.layer, null, 2) isEditing: false,
prevValue: this.getValue(),
};
} }
getValue () {
return JSON.stringify(this.props.layer, null, 2);
}
componentDidMount () {
this._doc = CodeMirror(this._el, {
value: this.getValue(),
mode: {
name: "javascript",
json: true
},
tabSize: 2,
theme: 'maputnik',
viewportMargin: Infinity,
lineNumbers: true,
lint: true,
gutters: ["CodeMirror-lint-markers"],
scrollbarStyle: "null",
});
this._doc.on('change', this.onChange);
this._doc.on('focus', this.onFocus);
this._doc.on('blur', this.onBlur);
}
onFocus = () => {
this.setState({
isEditing: true
});
}
onBlur = () => {
this.setState({
isEditing: false
});
}
componentWillUnMount () {
this._doc.off('change', this.onChange);
this._doc.off('focus', this.onFocus);
this._doc.off('blur', this.onBlur);
} }
componentDidUpdate(prevProps) { componentDidUpdate(prevProps) {
if (prevProps.layer !== this.props.layer) { if (!this.state.isEditing && prevProps.layer !== this.props.layer) {
this.setState({ this._cancelNextChange = true;
code: JSON.stringify(this.props.layer, null, 2) this._doc.setValue(
}) this.getValue(),
)
} }
} }
onCodeUpdate(newCode) { onChange = (e) => {
if (this._cancelNextChange) {
this._cancelNextChange = false;
return;
}
const newCode = this._doc.getValue();
if (this.state.prevValue !== newCode) {
try { try {
const parsedLayer = JSON.parse(newCode) const parsedLayer = JSON.parse(newCode)
this.props.onChange(parsedLayer) this.props.onChange(parsedLayer)
} catch(err) { } catch(err) {
console.warn(err) console.warn(err)
} finally {
this.setState({
code: newCode
})
} }
} }
resetValue() {
console.log('reset')
this.setState({ this.setState({
code: JSON.stringify(this.props.layer, null, 2) prevValue: newCode,
}) });
} }
render() { render() {
@ -69,12 +115,7 @@ class JSONEditor extends React.Component {
scrollbarStyle: "null", scrollbarStyle: "null",
} }
return <CodeMirror return <div ref={(el) => this._el = el} />
value={this.state.code}
onBeforeChange={(editor, data, value) => this.onCodeUpdate(value)}
onFocusChange={focused => focused ? true : this.resetValue()}
options={codeMirrorOptions}
/>
} }
} }