Added firefox tests and fixed docker deploy

.github/workflows/ci.yml

@@ -144,6 +144,45 @@ jobs:
     - name: artifacts/screenshots
       uses: actions/upload-artifact@v1
       with:
-        name: screenshots
+        name: screenshots-chrome
+        path: build/screenshots
+
+  # build and test the editor in standalone-firefox
+  test_selenium_standalone_firefox:
+    name: "test/standalone-firefox (${{ matrix.os }})"
+    runs-on: ${{ matrix.os }}
+
+    if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+        node-version: [10]
+
+    container:
+      image: node:${{ matrix.node-version }}
+      options: --network-alias testhost
+
+    services:
+      selenium:
+        image: selenium/standalone-firefox:3.141.59
+        ports:
+        - 4444:4444
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/cache@v1
+      with:
+        path: ~/.npm
+        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+        restore-keys: |
+          ${{ runner.os }}-node-
+    - run: npm install
+    - run: BROWSER=firefox TEST_NETWORK=testhost DOCKER_HOST=selenium npm test
+    - name: artifacts/screenshots
+      uses: actions/upload-artifact@v1
+      with:
+        name: screenshots-firefox
         path: build/screenshots
 

.github/workflows/deploy.yml

@@ -13,7 +13,7 @@ jobs:
     name: deploy/docker
     runs-on: ${{ matrix.os }}
 
-    if: ${{ github.event_name == 'push' && github.ref == 'master' }}
+    if: ${{ github.event_name == 'push' }}
 
     strategy:
       fail-fast: false

config/wdio.conf.js

@@ -16,10 +16,12 @@ exports.config = {
     './test/functional/index.js'
   ],
   maxInstances: 10,
-  capabilities: [{
-    maxInstances: 5,
-    browserName: 'chrome',
-  }],
+  capabilities: [
+    {
+      maxInstances: 5,
+      browserName: (process.env.BROWSER || 'chrome'),
+    }
+  ],
   logLevel: 'info',
   bail: 0,
   screenshotPath: SCREENSHOT_PATH,