schnabu/maputnik
1
0
Fork 0
mirror of https://github.com/a-nyx/maputnik-with-pmtiles.git synced 2024-12-28 01:15:26 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Lots of smaller fixes found in the console logs during testing.

Browse source
This commit is contained in:
orangemug 2020-04-06 13:59:08 +01:00
parent a1dedd1aa6
commit b8739915b2
6 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/App.jsx
View file

@ -353,7 +353,7 @@ export default class App extends React.Component {
parsed: { parsed: {
type: "layer", type: "layer",
data: { data: {
index, index: parseInt(index, 10),
key: "id", key: "id",
message, message,
} }
@ -371,7 +371,7 @@ export default class App extends React.Component {
parsed: { parsed: {
type: "layer", type: "layer",
data: { data: {
index, index: parseInt(index, 10),
key, key,
message message
} }

4
src/components/fields/DocLabel.jsx
View file

@ -9,8 +9,8 @@ export default class DocLabel extends React.Component {
PropTypes.object, PropTypes.object,
PropTypes.string PropTypes.string
]).isRequired, ]).isRequired,
fieldSpec: PropTypes.object.isRequired, fieldSpec: PropTypes.object,
onToggleDoc: PropTypes.func.isRequired, onToggleDoc: PropTypes.func,
} }
constructor (props) { constructor (props) {

6
src/components/filter/FilterEditor.jsx
View file

@ -223,7 +223,7 @@ export default class CombiningFilterEditor extends React.Component {
const error = errors[`filter[${idx+1}]`]; const error = errors[`filter[${idx+1}]`];
return ( return (
<> <div key={`block-${idx}`}>
<FilterEditorBlock key={idx} onDelete={this.deleteFilterItem.bind(this, idx)}> <FilterEditorBlock key={idx} onDelete={this.deleteFilterItem.bind(this, idx)}>
<SingleFilterEditor <SingleFilterEditor
properties={this.props.properties} properties={this.props.properties}
@ -232,9 +232,9 @@ export default class CombiningFilterEditor extends React.Component {
/> />
</FilterEditorBlock> </FilterEditorBlock>
{error && {error &&
<div className="maputnik-inline-error">{error.message}</div> <div key="error" className="maputnik-inline-error">{error.message}</div>
} }
</> </div>
); );
}) })

1
src/components/inputs/StringInput.jsx
View file

@ -33,6 +33,7 @@ class StringInput extends React.Component {
value: props.value value: props.value
}; };
} }
return {};
} }
render() { render() {

2
src/components/layers/LayerIdBlock.jsx
View file

@ -10,7 +10,7 @@ class LayerIdBlock extends React.Component {
value: PropTypes.string.isRequired, value: PropTypes.string.isRequired,
wdKey: PropTypes.string.isRequired, wdKey: PropTypes.string.isRequired,
onChange: PropTypes.func.isRequired, onChange: PropTypes.func.isRequired,
error: PropTypes.object.isRequired, error: PropTypes.object,
} }
render() { render() {

6
src/components/layers/LayerList.jsx
View file

@ -165,12 +165,14 @@ class LayerListContainer extends React.Component {
return propsChanged; return propsChanged;
} }
componentDidUpdate () { componentDidUpdate (prevProps) {
if (prevProps.selectedLayerIndex !== this.props.selectedLayerIndex) {
const selectedItemNode = this.selectedItemRef.current; const selectedItemNode = this.selectedItemRef.current;
if (selectedItemNode && selectedItemNode.node) { if (selectedItemNode && selectedItemNode.node) {
selectedItemNode.node.scrollIntoView(); selectedItemNode.node.scrollIntoView();
} }
} }
}
render() { render() {
@ -184,7 +186,7 @@ class LayerListContainer extends React.Component {
if(layers.length > 1) { if(layers.length > 1) {
const grp = <LayerListGroup const grp = <LayerListGroup
data-wd-key={[groupPrefix, idx].join('-')} data-wd-key={[groupPrefix, idx].join('-')}
key={`group-${groupPrefix}`} key={`group-${groupPrefix}-${idx}`}
title={groupPrefix} title={groupPrefix}
isActive={!this.isCollapsed(groupPrefix, idx) || idx === this.props.selectedLayerIndex} isActive={!this.isCollapsed(groupPrefix, idx) || idx === this.props.selectedLayerIndex}
onActiveToggle={this.toggleLayerGroup.bind(this, groupPrefix, idx)} onActiveToggle={this.toggleLayerGroup.bind(this, groupPrefix, idx)}