code review: do not pollute logger with firewall noop rules

This commit is contained in:
gorhill 2017-06-14 08:32:12 -04:00
parent 5c588dae9b
commit 84f22ce3a6
No known key found for this signature in database
GPG key ID: 25E1490B761470C2

View file

@ -639,9 +639,9 @@ PageStore.prototype.filterRequest = function(context) {
// Dynamic hostname/type filtering.
if ( result === 0 && µb.userSettings.advancedUserEnabled ) {
result = µb.sessionFirewall.evaluateCellZY( context.rootHostname, context.requestHostname, requestType);
if ( result !== 0 && µb.logger.isEnabled() ) {
if ( result !== 0 && result !== 3 && µb.logger.isEnabled() ) {
this.logData = µb.sessionFirewall.toLogData();
}
}
}
// Static filtering: lowest filtering precedence.
@ -732,7 +732,7 @@ PageStore.prototype.filterRequestNoCache = function(context) {
// Dynamic hostname/type filtering.
if ( result === 0 && µb.userSettings.advancedUserEnabled ) {
result = µb.sessionFirewall.evaluateCellZY(context.rootHostname, context.requestHostname, requestType);
if ( result !== 0 && µb.logger.isEnabled() ) {
if ( result !== 0 && result !== 3 && µb.logger.isEnabled() ) {
this.logData = µb.sessionFirewall.toLogData();
}
}